* [patch 4/4] dell-wmi: support additional keys
@ 2009-04-11 6:16 akpm
2009-04-13 14:55 ` Matthew Garrett
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2009-04-11 6:16 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, akpm, rafi, E.A.B.Piel, len.brown, mjg
From: Rafi Rubin <rafi@seas.upenn.edu>
Added key codes generated by screen rotation on the Latitude XT. 0xe046
is sent when changing to tablet mode, and 0xe047 when it returns to
desktop mode.
Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Eric Piel <E.A.B.Piel@tudelft.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/platform/x86/dell-wmi.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/platform/x86/dell-wmi.c~dell-wmi-support-additional-keys drivers/platform/x86/dell-wmi.c
--- a/drivers/platform/x86/dell-wmi.c~dell-wmi-support-additional-keys
+++ a/drivers/platform/x86/dell-wmi.c
@@ -50,6 +50,8 @@ enum { KE_KEY, KE_SW, KE_END };
static struct key_entry dell_wmi_keymap[] = {
{KE_KEY, 0xe045, KEY_PROG1},
+ {KE_KEY, 0xe046, KEY_PROG2},
+ {KE_KEY, 0xe047, KEY_PROG3},
{KE_END, 0}
};
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 4/4] dell-wmi: support additional keys
2009-04-11 6:16 [patch 4/4] dell-wmi: support additional keys akpm
@ 2009-04-13 14:55 ` Matthew Garrett
2009-04-15 14:04 ` Len Brown
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Garrett @ 2009-04-13 14:55 UTC (permalink / raw)
To: akpm; +Cc: lenb, linux-acpi, rafi, E.A.B.Piel, len.brown
On Fri, Apr 10, 2009 at 11:16:32PM -0700, akpm@linux-foundation.org wrote:
> From: Rafi Rubin <rafi@seas.upenn.edu>
>
> Added key codes generated by screen rotation on the Latitude XT. 0xe046
> is sent when changing to tablet mode, and 0xe047 when it returns to
> desktop mode.
>
> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Eric Piel <E.A.B.Piel@tudelft.nl>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I don't like this - it should really be using the switch event, not
sending random programmable buttons.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-15 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-11 6:16 [patch 4/4] dell-wmi: support additional keys akpm
2009-04-13 14:55 ` Matthew Garrett
2009-04-15 14:04 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.