All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] ext4: really print the find_group_flex fallback warning only once
@ 2009-04-13 23:03 Chuck Ebbert
  2009-04-14 11:30 ` Theodore Tso
  0 siblings, 1 reply; 2+ messages in thread
From: Chuck Ebbert @ 2009-04-13 23:03 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: linux-ext4

ext4: really print the find_group_flex fallback warning only once

Missing braces caused the warning to print more than once.

Signed-Off-By: Chuck Ebbert <cebbert@redhat.com>

--- linux-2.6.27.noarch.orig/fs/ext4/ialloc.c
+++ linux-2.6.27.noarch/fs/ext4/ialloc.c
@@ -705,11 +705,12 @@ struct inode *ext4_new_inode(handle_t *h
 		ret2 = find_group_flex(sb, dir, &group);
 		if (ret2 == -1) {
 			ret2 = find_group_other(sb, dir, &group);
-			if (ret2 == 0 && once)
+			if (ret2 == 0 && once) {
 				once = 0;
 				printk(KERN_NOTICE "ext4: find_group_flex "
 				       "failed, fallback succeeded dir %lu\n",
 				       dir->i_ino);
+			}
 		}
 		goto got_group;
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] ext4: really print the find_group_flex fallback warning only once
  2009-04-13 23:03 [patch] ext4: really print the find_group_flex fallback warning only once Chuck Ebbert
@ 2009-04-14 11:30 ` Theodore Tso
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2009-04-14 11:30 UTC (permalink / raw)
  To: Chuck Ebbert; +Cc: linux-ext4

On Mon, Apr 13, 2009 at 07:03:29PM -0400, Chuck Ebbert wrote:
> ext4: really print the find_group_flex fallback warning only once
> 
> Missing braces caused the warning to print more than once.

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-14 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-13 23:03 [patch] ext4: really print the find_group_flex fallback warning only once Chuck Ebbert
2009-04-14 11:30 ` Theodore Tso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.