From: Christoph Hellwig <hch@lst.de>
To: Theodore Tso <tytso@mit.edu>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Zhaolei <zhaolei@cn.fujitsu.com>, Li Zefan <lizf@cn.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
"Frank Ch. Eigler" <fche@elastic.org>,
Tom Zanussi <tzanussi@gmail.com>,
Jiaying Zhang <jiayingz@google.com>,
Michael Rubin <mrubin@google.com>,
Martin Bligh <mbligh@google.com>
Subject: Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules
Date: Thu, 16 Apr 2009 18:52:24 +0200 [thread overview]
Message-ID: <20090416165224.GD5933@lst.de> (raw)
In-Reply-To: <20090414210445.GM955@mit.edu>
On Tue, Apr 14, 2009 at 05:04:45PM -0400, Theodore Tso wrote:
> One thing which I would really like is to avoid needing to drop the
> header file in include/trace/<subsystem.h>.
>
> The problem that I have with this is that for ext4, we need to access
> private data structures which are defined in header files in
> fs/ext4/*.h --- which we moved into fs/ext4 a long time ago at the
> request of those who felt include/linux/* was getting rather
> cluttered, and if a subsystem had header files which were only needed
> by files for that particular subsystems, they should be moved out of
> include/linux.
Same is true for XFS, or just about any other self-contained in a module
subsystem I can think of. My current XFS trace events stuff includes
tons of headers in the xfs header in include/trace and adds -Ifs/xfs to
kernel/trace/Makefile. The latter should be gone by the new
implementation compiling the tracing stubs into the module, but it's
still not pretty.
prev parent reply other threads:[~2009-04-16 16:55 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 17:23 [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules Steven Rostedt
2009-04-14 17:23 ` [PATCH 1/8] tracing: consolidate trace and trace_event headers Steven Rostedt
2009-04-14 21:51 ` Frederic Weisbecker
2009-04-14 22:04 ` Steven Rostedt
2009-04-14 17:23 ` [PATCH 2/8] tracing: create automated trace defines Steven Rostedt
2009-04-14 23:44 ` Jeremy Fitzhardinge
2009-04-15 1:45 ` Mathieu Desnoyers
2009-04-15 16:07 ` Jeremy Fitzhardinge
2009-04-16 2:34 ` Mathieu Desnoyers
2009-04-16 2:56 ` Jeremy Fitzhardinge
2009-04-16 23:44 ` Mathieu Desnoyers
2009-04-17 0:03 ` Jeremy Fitzhardinge
2009-04-17 0:13 ` Mathieu Desnoyers
2009-04-17 0:18 ` Jeremy Fitzhardinge
2009-04-17 0:28 ` Mathieu Desnoyers
2009-04-17 0:43 ` Jeremy Fitzhardinge
2009-04-17 3:05 ` [PATCH] tracepoints : let subsystem nop-out the tracepoints at build time Mathieu Desnoyers
2009-04-20 7:12 ` [PATCH 2/8] tracing: create automated trace defines Andi Kleen
2009-04-21 15:51 ` Mathieu Desnoyers
2009-04-21 17:18 ` Jeremy Fitzhardinge
2009-04-21 17:21 ` Steven Rostedt
2009-04-21 17:43 ` Jeremy Fitzhardinge
2009-04-21 20:28 ` Andi Kleen
2009-04-21 21:17 ` Steven Rostedt
2009-04-21 21:23 ` Frank Ch. Eigler
2009-04-21 21:33 ` Steven Rostedt
2009-04-22 5:47 ` Mathieu Desnoyers
2009-04-22 6:07 ` Andi Kleen
2009-04-22 6:24 ` Steven Rostedt
2009-04-22 7:26 ` Andi Kleen
2009-04-15 7:04 ` Zhaolei
2009-04-14 17:23 ` [PATCH 3/8] tracing: make trace_seq operations available for core kernel Steven Rostedt
2009-04-14 19:12 ` Peter Zijlstra
2009-04-15 2:19 ` Steven Rostedt
2009-04-14 17:23 ` [PATCH 4/8] tracing/events: move declarations from trace directory to core include Steven Rostedt
2009-04-14 17:23 ` [PATCH 5/8] tracing/events: move the ftrace event tracing code to core Steven Rostedt
2009-04-14 19:23 ` Peter Zijlstra
2009-04-15 2:25 ` Steven Rostedt
2009-04-15 3:40 ` Jiaying Zhang
2009-04-14 17:23 ` [PATCH 6/8] tracing/events: convert event call sites to use a link list Steven Rostedt
2009-04-14 17:23 ` [PATCH 7/8] tracing/events: add export symbols for trace events in modules Steven Rostedt
2009-04-14 17:23 ` [PATCH 8/8] tracing/events: add support for modules to TRACE_EVENT Steven Rostedt
2009-04-15 3:22 ` Rusty Russell
2009-04-14 18:15 ` [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules Ingo Molnar
2009-04-14 18:25 ` Ingo Molnar
2009-04-14 18:21 ` Ingo Molnar
2009-04-14 18:33 ` Steven Rostedt
2009-04-14 18:35 ` Ingo Molnar
2009-04-14 21:04 ` Theodore Tso
2009-04-14 21:23 ` Steven Rostedt
2009-04-14 21:59 ` Steven Rostedt
2009-04-14 21:29 ` Frank Ch. Eigler
2009-04-14 22:00 ` Steven Rostedt
2009-04-16 16:53 ` Christoph Hellwig
2009-04-14 21:48 ` Jeremy Fitzhardinge
2009-04-14 21:55 ` Steven Rostedt
2009-04-14 22:33 ` Jeremy Fitzhardinge
2009-04-15 8:29 ` Ingo Molnar
2009-04-16 2:29 ` Mathieu Desnoyers
2009-04-16 16:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416165224.GD5933@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=compudj@krystal.dyndns.org \
--cc=fche@elastic.org \
--cc=fweisbec@gmail.com \
--cc=jeremy@goop.org \
--cc=jiayingz@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mbligh@google.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=mrubin@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.