All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	torvalds@osdl.org, stable@kernel.org
Subject: [PATCH] Please revert console ASCII glyph 1:1 mapping
Date: Sat, 18 Apr 2009 22:17:17 +0200	[thread overview]
Message-ID: <20090418201717.GL21409@const> (raw)

This reverts commit 1c55f187 (console ASCII glyph 1:1 mapping):  Ingo
was assuming that reverting to 1:1 mapping for chars >= 128 was not
useful, but it happens to be: due to the limitations of the Linux
console, when a blind user wants to read BIG5 on it, he has no other
way than loading a font without SFM and let the 1:1 mapping permit the
screen reader to get the BIG5 encoding.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

reverted:
--- b/drivers/char/vt.c
+++ a/drivers/char/vt.c
@@ -2274,7 +2274,7 @@
 				    continue; /* nothing to display */
 				}
 				/* Glyph not found */
+				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) || c < 128) && !(c & ~charmask)) {
-				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) && c < 128) && !(c & ~charmask)) {
 				    /* In legacy mode use the glyph we get by a 1:1 mapping.
 				       This would make absolutely no sense with Unicode in mind,
 				       but do this for ASCII characters since a font may lack

             reply	other threads:[~2009-04-18 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-18 20:17 Samuel Thibault [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-04-18 20:17 [PATCH] Please revert console ASCII glyph 1:1 mapping Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090418201717.GL21409@const \
    --to=samuel.thibault@ens-lyon.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.