All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Please revert console ASCII glyph 1:1 mapping
@ 2009-04-18 20:17 Samuel Thibault
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2009-04-18 20:17 UTC (permalink / raw)
  To: linux-kernel, akpm, torvalds, stable

This reverts commit 1c55f187 (console ASCII glyph 1:1 mapping):  Ingo
was assuming that reverting to 1:1 mapping for chars >= 128 was not
useful, but it happens to be: due to the limitations of the Linux
console, when a blind user wants to read BIG5 on it, he has no other
way than loading a font without SFM and let the 1:1 mapping permit the
screen reader to get the BIG5 encoding.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

reverted:
--- b/drivers/char/vt.c
+++ a/drivers/char/vt.c
@@ -2274,7 +2274,7 @@
 				    continue; /* nothing to display */
 				}
 				/* Glyph not found */
+				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) || c < 128) && !(c & ~charmask)) {
-				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) && c < 128) && !(c & ~charmask)) {
 				    /* In legacy mode use the glyph we get by a 1:1 mapping.
 				       This would make absolutely no sense with Unicode in mind,
 				       but do this for ASCII characters since a font may lack

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH] Please revert console ASCII glyph 1:1 mapping
@ 2009-04-18 20:17 Samuel Thibault
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2009-04-18 20:17 UTC (permalink / raw)
  To: linux-kernel, akpm, torvalds, stable

This reverts commit 1c55f187 (console ASCII glyph 1:1 mapping):  Ingo
was assuming that reverting to 1:1 mapping for chars >= 128 was not
useful, but it happens to be: due to the limitations of the Linux
console, when a blind user wants to read BIG5 on it, he has no other
way than loading a font without SFM and let the 1:1 mapping permit the
screen reader to get the BIG5 encoding.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

reverted:
--- b/drivers/char/vt.c
+++ a/drivers/char/vt.c
@@ -2274,7 +2274,7 @@
 				    continue; /* nothing to display */
 				}
 				/* Glyph not found */
+				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) || c < 128) && !(c & ~charmask)) {
-				if ((!(vc->vc_utf && !vc->vc_disp_ctrl) && c < 128) && !(c & ~charmask)) {
 				    /* In legacy mode use the glyph we get by a 1:1 mapping.
 				       This would make absolutely no sense with Unicode in mind,
 				       but do this for ASCII characters since a font may lack

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-18 20:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-18 20:17 [PATCH] Please revert console ASCII glyph 1:1 mapping Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2009-04-18 20:17 Samuel Thibault

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.