Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut <marek.vasut@gmail.com>]

On Tuesday 21 of April 2009 06:02:59 Eric Miao wrote:
> On Mon, Mar 23, 2009 at 5:23 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux 
napsal(a):
> >> > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> >> > > This patch adds palmld ide channel support, same as previous patch,
> >> > > I think this can be merged since it wont break anything.
> >> >
> >> > I think this one also needs review by the Linux ATA folk.  Mention to
> >> > them that it's part of a patchset for ARM and that you'd prefer it
> >> > to be merged into the ARM tree.
> >> >
> >> > > +static const char drvname[] = "pata_palmld";
> >> > > +MODULE_ALIAS("platform: "drvname);
> >> >
> >> > Have you tried building this as a module?  Also, IIRC, there isn't
> >> > supposed to be a space after the colon...
> >>
> >> Ok, I fixed the issues and CCed linux-ide and the maintainer.
> >>
> >> Thanks
> >
> > Hi, Im resending this patch since it was totally ignored last time. It
> > still applies correctly. It'd be for the best to push this through
> > arm-kernel tree.
>
> I wonder if this driver can be implemented in a more generic way so
> that other boards can be benefited. The only specific things I see are:
>
> 1. I/O mapping address space
> 2. IRQ
> 3. PowerON
>
> IRQ can be specified by platform_data, and power_on can be implemented
> by callbacks in platform_data. I/O mapping should be OK by resources in
> platform_device.
>
> So what's else to make this specific to PalmLD?

Will there be anyone who would use that other than palmld then ? I doubt 
anyone has that obscure hardware. That's why I see no point in making this 
generic.