From: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
"OF-EWG" <ewg@lists.openfabrics.org>,
Roland Dreier <rolandd@cisco.com>
Cc: alexschm@de.ibm.com, fenkes@de.ibm.com,
stefan.roscher@de.ibm.com, raisch@de.ibm.com
Subject: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc
Date: Tue, 21 Apr 2009 17:16:44 +0200 [thread overview]
Message-ID: <200904211716.45245.ossrosch@linux.vnet.ibm.com> (raw)
From: Anton Blanchard <antonb at au1.ibm.com>
To improve performance of driver ressource allocation,
replace the vmalloc() call with kmalloc().
Signed-off-by: Stefan Roscher <stefan.roscher at de.ibm.com>
---
drivers/infiniband/hw/ehca/ipz_pt_fn.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ipz_pt_fn.c b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
index c3a3284..a260559 100644
--- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c
+++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
@@ -220,7 +220,7 @@ int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
queue->small_page = NULL;
/* allocate queue page pointers */
- queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
+ queue->queue_pages = kmalloc(nr_of_pages * sizeof(void *), GFP_KERNEL);
if (!queue->queue_pages) {
ehca_gen_err("Couldn't allocate queue page list");
return 0;
@@ -240,7 +240,7 @@ int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
ipz_queue_ctor_exit0:
ehca_gen_err("Couldn't alloc pages queue=%p "
"nr_of_pages=%x", queue, nr_of_pages);
- vfree(queue->queue_pages);
+ kfree(queue->queue_pages);
return 0;
}
@@ -262,7 +262,7 @@ int ipz_queue_dtor(struct ehca_pd *pd, struct ipz_queue *queue)
free_page((unsigned long)queue->queue_pages[i]);
}
- vfree(queue->queue_pages);
+ kfree(queue->queue_pages);
return 1;
}
--
1.5.5
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
"OF-EWG" <ewg@lists.openfabrics.org>,
Roland Dreier <rolandd@cisco.com>
Cc: fenkes@de.ibm.com, raisch@de.ibm.com, alexschm@de.ibm.com,
stefan.roscher@de.ibm.com, hnguyen@de.ibm.com
Subject: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc
Date: Tue, 21 Apr 2009 17:16:44 +0200 [thread overview]
Message-ID: <200904211716.45245.ossrosch@linux.vnet.ibm.com> (raw)
From: Anton Blanchard <antonb at au1.ibm.com>
To improve performance of driver ressource allocation,
replace the vmalloc() call with kmalloc().
Signed-off-by: Stefan Roscher <stefan.roscher at de.ibm.com>
---
drivers/infiniband/hw/ehca/ipz_pt_fn.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ipz_pt_fn.c b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
index c3a3284..a260559 100644
--- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c
+++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
@@ -220,7 +220,7 @@ int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
queue->small_page = NULL;
/* allocate queue page pointers */
- queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *));
+ queue->queue_pages = kmalloc(nr_of_pages * sizeof(void *), GFP_KERNEL);
if (!queue->queue_pages) {
ehca_gen_err("Couldn't allocate queue page list");
return 0;
@@ -240,7 +240,7 @@ int ipz_queue_ctor(struct ehca_pd *pd, struct ipz_queue *queue,
ipz_queue_ctor_exit0:
ehca_gen_err("Couldn't alloc pages queue=%p "
"nr_of_pages=%x", queue, nr_of_pages);
- vfree(queue->queue_pages);
+ kfree(queue->queue_pages);
return 0;
}
@@ -262,7 +262,7 @@ int ipz_queue_dtor(struct ehca_pd *pd, struct ipz_queue *queue)
free_page((unsigned long)queue->queue_pages[i]);
}
- vfree(queue->queue_pages);
+ kfree(queue->queue_pages);
return 1;
}
--
1.5.5
next reply other threads:[~2009-04-21 15:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 15:16 Stefan Roscher [this message]
2009-04-21 15:16 ` [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc Stefan Roscher
2009-04-21 17:34 ` Roland Dreier
2009-04-21 17:34 ` Roland Dreier
2009-04-22 9:11 ` Stefan Roscher
2009-04-22 14:02 ` Stefan Roscher
2009-04-22 14:02 ` Stefan Roscher
2009-04-22 14:10 ` michael
2009-04-22 16:00 ` Stefan Roscher
2009-04-22 16:12 ` michael
2009-04-28 13:07 ` [ewg] " Alexander Schmidt
2009-04-28 14:01 ` Roland Dreier
2009-04-28 14:01 ` Roland Dreier
2009-04-28 14:13 ` Alexander Schmidt
2009-04-28 14:13 ` Alexander Schmidt
2009-04-28 15:12 ` Dave Hansen
2009-04-28 15:12 ` Dave Hansen
2009-04-28 16:02 ` Stefan Roscher
2009-04-28 16:02 ` Stefan Roscher
2009-04-28 16:45 ` Roland Dreier
2009-04-28 16:45 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904211716.45245.ossrosch@linux.vnet.ibm.com \
--to=ossrosch@linux.vnet.ibm.com \
--cc=alexschm@de.ibm.com \
--cc=ewg@lists.openfabrics.org \
--cc=fenkes@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=rolandd@cisco.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.