From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: subrata@linux.vnet.ibm.com
Cc: Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>, Greg KH <greg@kroah.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
sachinp <sachinp@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alexander Beregalov <a.beregalov@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]
Date: Tue, 21 Apr 2009 21:04:37 +0200 [thread overview]
Message-ID: <200904212104.38664.bzolnier@gmail.com> (raw)
In-Reply-To: <1239733759.5344.79.camel@subratamodak.linux.ibm.com>
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> ‘check_media_bay_by_base’
> drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> ‘media_bay_set_ide_infos’
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---
Should be fixed by:
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide-pmac: fix modular build for CONFIG_PMAC_MEDIABAY=y
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> ‘check_media_bay_by_base’
> drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> ‘media_bay_set_ide_infos’
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---
IDE PMAC host driver can be modular now so we need to export
check_media_bay_by_base() and media_bay_set_ide_infos().
Reported-by: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/macintosh/mediabay.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/macintosh/mediabay.c
===================================================================
--- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -447,6 +447,7 @@ int check_media_bay_by_base(unsigned lon
return -ENODEV;
}
+EXPORT_SYMBOL_GPL(check_media_bay_by_base);
int media_bay_set_ide_infos(struct device_node* which_bay, unsigned long base,
int irq, ide_hwif_t *hwif)
@@ -486,6 +487,7 @@ int media_bay_set_ide_infos(struct devic
return -ENODEV;
}
+EXPORT_SYMBOL_GPL(media_bay_set_ide_infos);
#endif /* CONFIG_BLK_DEV_IDE_PMAC */
static void media_bay_step(int i)
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: subrata@linux.vnet.ibm.com
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Greg KH <greg@kroah.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linuxppc-dev <Linuxppc-dev@ozlabs.org>,
linux-next <linux-next@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Alexander Beregalov <a.beregalov@gmail.com>
Subject: Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c]
Date: Tue, 21 Apr 2009 21:04:37 +0200 [thread overview]
Message-ID: <200904212104.38664.bzolnier@gmail.com> (raw)
In-Reply-To: <1239733759.5344.79.camel@subratamodak.linux.ibm.com>
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function =E2=80=98pmac_ide_init_dev=E2=80=99:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> =E2=80=98check_media_bay_by_base=E2=80=99
> drivers/ide/pmac.c: In function =E2=80=98pmac_ide_setup_device=E2=80=99:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> =E2=80=98media_bay_set_ide_infos=E2=80=99
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---
Should be fixed by:
=46rom: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide-pmac: fix modular build for CONFIG_PMAC_MEDIABAY=3Dy
On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote:
> Observed the following build error:
> ---
> CC [M] drivers/ide/pmac.o
> drivers/ide/pmac.c: In function =E2=80=98pmac_ide_init_dev=E2=80=99:
> drivers/ide/pmac.c:955: error: implicit declaration of function
> =E2=80=98check_media_bay_by_base=E2=80=99
> drivers/ide/pmac.c: In function =E2=80=98pmac_ide_setup_device=E2=80=99:
> drivers/ide/pmac.c:1090: error: implicit declaration of function
> =E2=80=98media_bay_set_ide_infos=E2=80=99
> make[2]: *** [drivers/ide/pmac.o] Error 1
> make[1]: *** [drivers/ide] Error 2
> make: *** [drivers] Error 2
> ---
IDE PMAC host driver can be modular now so we need to export
check_media_bay_by_base() and media_bay_set_ide_infos().
Reported-by: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
=2D--
drivers/macintosh/mediabay.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/macintosh/mediabay.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- a/drivers/macintosh/mediabay.c
+++ b/drivers/macintosh/mediabay.c
@@ -447,6 +447,7 @@ int check_media_bay_by_base(unsigned lon
=20
return -ENODEV;
}
+EXPORT_SYMBOL_GPL(check_media_bay_by_base);
=20
int media_bay_set_ide_infos(struct device_node* which_bay, unsigned long b=
ase,
int irq, ide_hwif_t *hwif)
@@ -486,6 +487,7 @@ int media_bay_set_ide_infos(struct devic
=20
return -ENODEV;
}
+EXPORT_SYMBOL_GPL(media_bay_set_ide_infos);
#endif /* CONFIG_BLK_DEV_IDE_PMAC */
=20
static void media_bay_step(int i)
next prev parent reply other threads:[~2009-04-21 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 18:29 [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c] Subrata Modak
2009-04-14 18:29 ` Subrata Modak
2009-04-14 20:04 ` Greg KH
2009-04-14 20:04 ` Greg KH
2009-04-21 19:04 ` Bartlomiej Zolnierkiewicz [this message]
2009-04-21 19:04 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904212104.38664.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=a.beregalov@gmail.com \
--cc=greg@kroah.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rjw@sisk.pl \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.