* LVM2/lib/metadata pv_map.c
@ 2009-04-23 16:41 mornfall
2009-04-24 0:30 ` Alasdair G Kergon
0 siblings, 1 reply; 2+ messages in thread
From: mornfall @ 2009-04-23 16:41 UTC (permalink / raw)
To: lvm-devel
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mornfall at sourceware.org 2009-04-23 16:41:28
Modified files:
lib/metadata : pv_map.c
Log message:
Do not include MISSING_PVs in allocation maps.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/pv_map.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34
--- LVM2/lib/metadata/pv_map.c 2008/11/04 15:07:44 1.33
+++ LVM2/lib/metadata/pv_map.c 2009/04/23 16:41:27 1.34
@@ -129,6 +129,9 @@
dm_list_iterate_items(pvl, pvs) {
if (!(pvl->pv->status & ALLOCATABLE_PV))
continue;
+ if (pvl->pv->status & MISSING_PV)
+ continue;
+ assert(pvl->pv->dev);
pvm = NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread* LVM2/lib/metadata pv_map.c
2009-04-23 16:41 LVM2/lib/metadata pv_map.c mornfall
@ 2009-04-24 0:30 ` Alasdair G Kergon
0 siblings, 0 replies; 2+ messages in thread
From: Alasdair G Kergon @ 2009-04-24 0:30 UTC (permalink / raw)
To: lvm-devel
On Thu, Apr 23, 2009 at 04:41:28PM -0000, mornfall at sourceware.org wrote:
> Do not include MISSING_PVs in allocation maps.
Ack.
WHATS_NEW ?
> + assert(pvl->pv->dev);
Please don't use 'assert'. It bypasses our logging mechanisms
and aborts the code making debugging harder.
Use log_error() with an informative message instead, for example.
Alasdair
--
agk at redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-24 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 16:41 LVM2/lib/metadata pv_map.c mornfall
2009-04-24 0:30 ` Alasdair G Kergon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.