All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: reiserfs-devel@vger.kernel.org
Subject: [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
Date: Thu, 23 Apr 2009 21:25:12 +0200	[thread overview]
Message-ID: <20090423192512.GA22819@lst.de> (raw)

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
which calls reiserfs_resize does have it currently but also expects it
to be held on return, so there's no business for the unlock_super here.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
--- linux-2.6.orig/fs/reiserfs/resize.c	2009-04-23 21:23:25.631074621 +0200
+++ linux-2.6/fs/reiserfs/resize.c	2009-04-23 21:23:29.435949732 +0200
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
 		if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
 			printk
 			    ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
-			unlock_super(s);
 			return -ENOMEM;
 		}
 		/* the new journal bitmaps are zero filled, now we copy in the bitmap

             reply	other threads:[~2009-04-23 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 19:25 Christoph Hellwig [this message]
2009-04-23 19:34 ` [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize Edward Shishkin
2009-06-18 21:18   ` Christoph Hellwig
2009-06-18 22:28     ` Edward Shishkin
2009-06-19  8:30 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423192512.GA22819@lst.de \
    --to=hch@lst.de \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.