* [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
@ 2009-04-23 19:25 Christoph Hellwig
2009-04-23 19:34 ` Edward Shishkin
2009-06-19 8:30 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2009-04-23 19:25 UTC (permalink / raw)
To: reiserfs-devel
Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
which calls reiserfs_resize does have it currently but also expects it
to be held on return, so there's no business for the unlock_super here.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
--- linux-2.6.orig/fs/reiserfs/resize.c 2009-04-23 21:23:25.631074621 +0200
+++ linux-2.6/fs/reiserfs/resize.c 2009-04-23 21:23:29.435949732 +0200
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
printk
("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
- unlock_super(s);
return -ENOMEM;
}
/* the new journal bitmaps are zero filled, now we copy in the bitmap
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
2009-04-23 19:25 [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize Christoph Hellwig
@ 2009-04-23 19:34 ` Edward Shishkin
2009-06-18 21:18 ` Christoph Hellwig
2009-06-19 8:30 ` Christoph Hellwig
1 sibling, 1 reply; 5+ messages in thread
From: Edward Shishkin @ 2009-04-23 19:34 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: reiserfs-devel
Christoph Hellwig wrote:
> Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
> which calls reiserfs_resize does have it currently but also expects it
> to be held on return, so there's no business for the unlock_super here.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
Acked by Edward Shishkin <edward.shishkin@gmail.com>
> Index: linux-2.6/fs/reiserfs/resize.c
> ===================================================================
> --- linux-2.6.orig/fs/reiserfs/resize.c 2009-04-23 21:23:25.631074621 +0200
> +++ linux-2.6/fs/reiserfs/resize.c 2009-04-23 21:23:29.435949732 +0200
> @@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
> if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
> printk
> ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
> - unlock_super(s);
> return -ENOMEM;
> }
> /* the new journal bitmaps are zero filled, now we copy in the bitmap
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
2009-04-23 19:34 ` Edward Shishkin
@ 2009-06-18 21:18 ` Christoph Hellwig
2009-06-18 22:28 ` Edward Shishkin
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2009-06-18 21:18 UTC (permalink / raw)
To: Edward Shishkin; +Cc: Christoph Hellwig, reiserfs-devel
On Thu, Apr 23, 2009 at 09:34:05PM +0200, Edward Shishkin wrote:
> Christoph Hellwig wrote:
> >Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
> >which calls reiserfs_resize does have it currently but also expects it
> >to be held on return, so there's no business for the unlock_super here.
> >
> >
> >Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
>
> Acked by Edward Shishkin <edward.shishkin@gmail.com>
Do you plan to push this to Linus?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
2009-06-18 21:18 ` Christoph Hellwig
@ 2009-06-18 22:28 ` Edward Shishkin
0 siblings, 0 replies; 5+ messages in thread
From: Edward Shishkin @ 2009-06-18 22:28 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: reiserfs-devel
Christoph Hellwig wrote:
> On Thu, Apr 23, 2009 at 09:34:05PM +0200, Edward Shishkin wrote:
>
>> Christoph Hellwig wrote:
>>
>>> Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
>>> which calls reiserfs_resize does have it currently but also expects it
>>> to be held on return, so there's no business for the unlock_super here.
>>>
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>>
>>>
>> Acked by Edward Shishkin <edward.shishkin@gmail.com>
>>
>
> Do you plan to push this to Linus?
Nup.
Please, send..
Thanks,
Edward.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
2009-04-23 19:25 [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize Christoph Hellwig
2009-04-23 19:34 ` Edward Shishkin
@ 2009-06-19 8:30 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2009-06-19 8:30 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, reiserfs-devel
Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
which calls reiserfs_resize does have it currently but also expects it
to be held on return, so there's no business for the unlock_super here.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked by Edward Shishkin <edward.shishkin@gmail.com>
Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
--- linux-2.6.orig/fs/reiserfs/resize.c 2009-04-23 21:23:25.631074621 +0200
+++ linux-2.6/fs/reiserfs/resize.c 2009-04-23 21:23:29.435949732 +0200
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
printk
("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
- unlock_super(s);
return -ENOMEM;
}
/* the new journal bitmaps are zero filled, now we copy in the bitmap
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-19 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23 19:25 [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize Christoph Hellwig
2009-04-23 19:34 ` Edward Shishkin
2009-06-18 21:18 ` Christoph Hellwig
2009-06-18 22:28 ` Edward Shishkin
2009-06-19 8:30 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.