From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Michal Simek <michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matthew Wilcox <matthew-Ztpu424NOJ8@public.gmane.org>
Subject: Re: USE_ELF_CORE_DUMP?
Date: Sun, 26 Apr 2009 11:21:03 +0200 [thread overview]
Message-ID: <20090426092103.GB8207@lst.de> (raw)
In-Reply-To: <49F16786.7010401-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
On Fri, Apr 24, 2009 at 09:17:26AM +0200, Michal Simek wrote:
> Christoph Hellwig wrote:
> > Currently all architectures but microblaze unconditionally define
> > USE_ELF_CORE_DUMP. The microblaze ommision seems like an error to
> > me, so can we just kill this ifdef and make sure we are the same
> > everywhere?
> >
> Where did you find it?
> I haven't seen in in mainline (noMMU kernel). It is in my MMU patches
> which I want to send for review soon.
USE_ELF_CORE_DUMP is defined in arch/x86/include/*/elf.h (or sometimes
elf_{32,64}.h) on all architectures but microblaze.
> For noMMU I use CONFIG_BINFMT_FLAT (binfmt_flat.c) where I don't need
> USE_ELF_CORE_DUMP
> For MMU I use CONFIG_BINFMT_ELF (binfmt_elf.c) where USE_ELF_CORE_DUMP
> make sense to me.
USE_ELF_CORE_DUMP only comes into play if CONFIG_ELF_CORE is set, so in
the mmu example above. These two are in fact always checked together,
so not setting USE_ELF_CORE_DUMP is an obscure way to disable elf core
dumps despite CONFIG_ELF_CORE being set.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Michal Simek <michal.simek@petalogix.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-arch@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au,
linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: Re: USE_ELF_CORE_DUMP?
Date: Sun, 26 Apr 2009 11:21:03 +0200 [thread overview]
Message-ID: <20090426092103.GB8207@lst.de> (raw)
Message-ID: <20090426092103.RzyM_oun-TIdoY8pLA5a14Sdr1x8s_FjQZ3HBWbAKCU@z> (raw)
In-Reply-To: <49F16786.7010401@petalogix.com>
On Fri, Apr 24, 2009 at 09:17:26AM +0200, Michal Simek wrote:
> Christoph Hellwig wrote:
> > Currently all architectures but microblaze unconditionally define
> > USE_ELF_CORE_DUMP. The microblaze ommision seems like an error to
> > me, so can we just kill this ifdef and make sure we are the same
> > everywhere?
> >
> Where did you find it?
> I haven't seen in in mainline (noMMU kernel). It is in my MMU patches
> which I want to send for review soon.
USE_ELF_CORE_DUMP is defined in arch/x86/include/*/elf.h (or sometimes
elf_{32,64}.h) on all architectures but microblaze.
> For noMMU I use CONFIG_BINFMT_FLAT (binfmt_flat.c) where I don't need
> USE_ELF_CORE_DUMP
> For MMU I use CONFIG_BINFMT_ELF (binfmt_elf.c) where USE_ELF_CORE_DUMP
> make sense to me.
USE_ELF_CORE_DUMP only comes into play if CONFIG_ELF_CORE is set, so in
the mmu example above. These two are in fact always checked together,
so not setting USE_ELF_CORE_DUMP is an obscure way to disable elf core
dumps despite CONFIG_ELF_CORE being set.
next prev parent reply other threads:[~2009-04-26 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 18:33 USE_ELF_CORE_DUMP? Christoph Hellwig
2009-04-23 18:48 ` USE_ELF_CORE_DUMP? Matthew Wilcox
2009-04-24 7:17 ` USE_ELF_CORE_DUMP? Michal Simek
[not found] ` <49F16786.7010401-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org>
2009-04-26 9:21 ` Christoph Hellwig [this message]
2009-04-26 9:21 ` USE_ELF_CORE_DUMP? Christoph Hellwig
2009-09-26 19:50 ` [PATCH] kill USE_ELF_CORE_DUMP Christoph Hellwig
2009-09-26 20:03 ` Hugh Dickins
2009-09-29 12:05 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426092103.GB8207@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthew-Ztpu424NOJ8@public.gmane.org \
--cc=michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org \
--cc=microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.