From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
Hugh Dickins <hugh@veritas.com>,
stable@kernel.org
Subject: [PATCH] ptrace: ptrace_attach: fix the usage of ->cred_exec_mutex
Date: Mon, 27 Apr 2009 01:41:34 +0200 [thread overview]
Message-ID: <20090426234134.GA13391@redhat.com> (raw)
In-Reply-To: <394.1240686417@redhat.com>
ptrace_attach() needs task->cred_exec_mutex, not current->cred_exec_mutex.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- PTRACE/kernel/ptrace.c~ 2009-04-15 12:53:58.000000000 +0200
+++ PTRACE/kernel/ptrace.c 2009-04-27 01:22:51.000000000 +0200
@@ -188,7 +188,7 @@ int ptrace_attach(struct task_struct *ta
/* Protect exec's credential calculations against our interference;
* SUID, SGID and LSM creds get determined differently under ptrace.
*/
- retval = mutex_lock_interruptible(¤t->cred_exec_mutex);
+ retval = mutex_lock_interruptible(&task->cred_exec_mutex);
if (retval < 0)
goto out;
@@ -232,7 +232,7 @@ repeat:
bad:
write_unlock_irqrestore(&tasklist_lock, flags);
task_unlock(task);
- mutex_unlock(¤t->cred_exec_mutex);
+ mutex_unlock(&task->cred_exec_mutex);
out:
return retval;
}
next prev parent reply other threads:[~2009-04-26 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 21:22 [PATCH] ptrace: tracehook_unsafe_exec: remove the stale comment Oleg Nesterov
2009-04-23 23:27 ` Roland McGrath
2009-04-24 16:39 ` ptrace && cred_exec_mutex (Was: [PATCH] ptrace: tracehook_unsafe_exec: remove the stale comment) Oleg Nesterov
2009-04-24 19:38 ` Roland McGrath
2009-04-25 10:54 ` David Howells
2009-04-25 17:25 ` Oleg Nesterov
2009-04-25 19:06 ` David Howells
2009-04-26 23:41 ` Oleg Nesterov [this message]
2009-04-27 2:11 ` [PATCH] ptrace: ptrace_attach: fix the usage of ->cred_exec_mutex Roland McGrath
2009-04-27 8:47 ` David Howells
2009-04-27 10:52 ` [GIT] " James Morris
2009-04-27 20:05 ` [PATCH] ptrace-tracehook_unsafe_exec-remove-the-stale-comment-fix Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426234134.GA13391@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.