All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] ptrace-tracehook_unsafe_exec-remove-the-stale-comment-fix
Date: Mon, 27 Apr 2009 22:05:10 +0200	[thread overview]
Message-ID: <20090427200510.GA6792@redhat.com> (raw)
In-Reply-To: <20090423232717.975ABFC3C7@magilla.sf.frob.com>

(on top of ptrace-tracehook_unsafe_exec-remove-the-stale-comment.patch)

On 04/23, Roland McGrath wrote:
>
> > tracehook_unsafe_exec() doesn't need task_lock(), remove the old comment.
>
> Please make it instead say that cred_exec_mutex is held by the caller
> through the exec.

Thanks.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>

--- PTRACE/include/linux/tracehook.h~COMMENT_FIX	2009-04-23 23:20:20.000000000 +0200
+++ PTRACE/include/linux/tracehook.h	2009-04-27 21:59:54.000000000 +0200
@@ -142,6 +142,8 @@ static inline void tracehook_report_sysc
  * @task:		current task doing exec
  *
  * Return %LSM_UNSAFE_* bits applied to an exec because of tracing.
+ *
+ * task->cred_exec_mutex is held by the caller through the do_execve().
  */
 static inline int tracehook_unsafe_exec(struct task_struct *task)
 {


      parent reply	other threads:[~2009-04-27 20:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 21:22 [PATCH] ptrace: tracehook_unsafe_exec: remove the stale comment Oleg Nesterov
2009-04-23 23:27 ` Roland McGrath
2009-04-24 16:39   ` ptrace && cred_exec_mutex (Was: [PATCH] ptrace: tracehook_unsafe_exec: remove the stale comment) Oleg Nesterov
2009-04-24 19:38     ` Roland McGrath
2009-04-25 10:54     ` David Howells
2009-04-25 17:25       ` Oleg Nesterov
2009-04-25 19:06         ` David Howells
2009-04-26 23:41           ` [PATCH] ptrace: ptrace_attach: fix the usage of ->cred_exec_mutex Oleg Nesterov
2009-04-27  2:11             ` Roland McGrath
2009-04-27  8:47             ` David Howells
2009-04-27 10:52               ` [GIT] " James Morris
2009-04-27 20:05   ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090427200510.GA6792@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.