From: Christoph Hellwig <hch@lst.de>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [MIPS] Resolve compile issues with msp71xx configuration
Date: Mon, 27 Apr 2009 15:27:03 +0200 [thread overview]
Message-ID: <20090427132703.GA16015@lst.de> (raw)
In-Reply-To: <E1LyQQX-00047N-6E@localhost>
On Mon, Apr 27, 2009 at 06:59:17AM -0600, Shane McDonald wrote:
> #ifdef CONFIG_SQUASHFS
> -#include <linux/squashfs_fs.h>
> +#include <linux/magic.h>
> +#include "../../../../fs/squashfs/squashfs_fs.h"
> #endif
Sorry guys, this has zero business to be there. Filesystem magic checks
of any sort don't belong into platform code. Please kill that whole
get_ramroot piece of junk.
prev parent reply other threads:[~2009-04-27 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 12:59 [MIPS] Resolve compile issues with msp71xx configuration Shane McDonald
2009-04-27 13:09 ` Ralf Baechle
2009-04-27 13:18 ` Sergei Shtylyov
2009-04-28 5:36 ` Shane McDonald
2009-04-27 13:22 ` Geert Uytterhoeven
2009-04-28 6:21 ` Shane McDonald
2009-04-28 7:16 ` Geert Uytterhoeven
2009-04-28 9:21 ` Christoph Hellwig
2009-04-28 10:50 ` Kevin D. Kissell
2009-04-28 9:20 ` Christoph Hellwig
2009-04-28 14:48 ` Shane McDonald
2009-04-28 15:05 ` Florian Fainelli
2009-04-28 15:55 ` Shane McDonald
2009-04-28 15:09 ` Ralf Baechle
2009-04-27 13:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427132703.GA16015@lst.de \
--to=hch@lst.de \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.