From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Shane McDonald <mcdonald.shane@gmail.com>,
linux-mips@linux-mips.org
Subject: Re: [MIPS] Resolve compile issues with msp71xx configuration
Date: Tue, 28 Apr 2009 11:20:05 +0200 [thread overview]
Message-ID: <20090428092005.GA2408@lst.de> (raw)
In-Reply-To: <10f740e80904270622u730ba067g660257847dc526de@mail.gmail.com>
On Mon, Apr 27, 2009 at 03:22:33PM +0200, Geert Uytterhoeven wrote:
> He needs the definition of struct squashfs_super_block to access the .bytes_used
> field. Alternatively, the offset of that field must be hardcoded.
No, that whole crap needs to go. FS code has no business poking into fs
internal structures. BTW, this whole setup is really, really gross,
it's mtd map driver calling arch code to get base + size for mapping,
poking into fs internal structures. I really wonder what people have
been smoking to come up with crap like that.
We should just leave it uncompilable as a sign for future generations
not to such stupid stuff.
next prev parent reply other threads:[~2009-04-28 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 12:59 [MIPS] Resolve compile issues with msp71xx configuration Shane McDonald
2009-04-27 13:09 ` Ralf Baechle
2009-04-27 13:18 ` Sergei Shtylyov
2009-04-28 5:36 ` Shane McDonald
2009-04-27 13:22 ` Geert Uytterhoeven
2009-04-28 6:21 ` Shane McDonald
2009-04-28 7:16 ` Geert Uytterhoeven
2009-04-28 9:21 ` Christoph Hellwig
2009-04-28 10:50 ` Kevin D. Kissell
2009-04-28 9:20 ` Christoph Hellwig [this message]
2009-04-28 14:48 ` Shane McDonald
2009-04-28 15:05 ` Florian Fainelli
2009-04-28 15:55 ` Shane McDonald
2009-04-28 15:09 ` Ralf Baechle
2009-04-27 13:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428092005.GA2408@lst.de \
--to=hch@lst.de \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.