All of lore.kernel.org
 help / color / mirror / Atom feed
* [MIPS] Resolve use of non-existent GPIO routines in msp71xx reset
@ 2009-04-28  5:52 Shane McDonald
  2009-04-28  9:17 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Shane McDonald @ 2009-04-28  5:52 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf

There have been a number of compile problems with the msp71xx
configuration ever since it was included in the linux-mips.org
repository.  This patch resolves compilation problems with attempting
to reset the board using non-existent GPIO routines.

This patch has been compile-tested against the current HEAD.

Signed-off-by: Shane McDonald <mcdonald.shane@gmail.com>
---
 arch/mips/pmc-sierra/msp71xx/msp_setup.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/mips/pmc-sierra/msp71xx/msp_setup.c b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
index c936756..a54e85b 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_setup.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
@@ -21,7 +21,6 @@
 
 #if defined(CONFIG_PMC_MSP7120_GW)
 #include <msp_regops.h>
-#include <msp_gpio.h>
 #define MSP_BOARD_RESET_GPIO	9
 #endif
 
@@ -88,11 +87,8 @@ void msp7120_reset(void)
 	 * as GPIO char driver may not be enabled and it would look up
 	 * data inRAM!
 	 */
-	set_value_reg32(GPIO_CFG3_REG,
-			basic_mode_mask(MSP_BOARD_RESET_GPIO),
-			basic_mode(MSP_GPIO_OUTPUT, MSP_BOARD_RESET_GPIO));
-	set_reg32(GPIO_DATA3_REG,
-			basic_data_mask(MSP_BOARD_RESET_GPIO));
+	set_value_reg32(GPIO_CFG3_REG, 0xf000, 0x8000);
+	set_reg32(GPIO_DATA3_REG, 8);
 
 	/*
 	 * In case GPIO9 doesn't reset the board (jumper configurable!)
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [MIPS] Resolve use of non-existent GPIO routines in msp71xx reset
  2009-04-28  5:52 [MIPS] Resolve use of non-existent GPIO routines in msp71xx reset Shane McDonald
@ 2009-04-28  9:17 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2009-04-28  9:17 UTC (permalink / raw)
  To: Shane McDonald; +Cc: linux-mips

On Mon, Apr 27, 2009 at 11:52:25PM -0600, Shane McDonald wrote:

> There have been a number of compile problems with the msp71xx
> configuration ever since it was included in the linux-mips.org
> repository.  This patch resolves compilation problems with attempting
> to reset the board using non-existent GPIO routines.
> 
> This patch has been compile-tested against the current HEAD.

Thanks, applied to 2.6.23 and up.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-28  9:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-28  5:52 [MIPS] Resolve use of non-existent GPIO routines in msp71xx reset Shane McDonald
2009-04-28  9:17 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.