From: David Brownell <david-b@pacbell.net>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Mika Korhonen <mika.j.korhonen@gmail.com>,
linux-mtd Mailing List <linux-mtd@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
Date: Wed, 29 Apr 2009 10:55:51 -0700 [thread overview]
Message-ID: <200904291055.51333.david-b@pacbell.net> (raw)
In-Reply-To: <49F852EB.1080701@nokia.com>
On Wednesday 29 April 2009, Adrian Hunter wrote:
> + .shutdown = __devexit_p(omap2_onenand_shutdown),
That looks wrong. Shutdown functions shouldn't get discarded
like exit functions. I'd think the fix for that would be taking
away any __devexit annotation on the shutdown function.
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Mika Korhonen <mika.j.korhonen@gmail.com>,
linux-mtd Mailing List <linux-mtd@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] OMAP OneNAND: add missing __devexit_p wrappers
Date: Wed, 29 Apr 2009 10:55:51 -0700 [thread overview]
Message-ID: <200904291055.51333.david-b@pacbell.net> (raw)
In-Reply-To: <49F852EB.1080701@nokia.com>
On Wednesday 29 April 2009, Adrian Hunter wrote:
> + .shutdown = __devexit_p(omap2_onenand_shutdown),
That looks wrong. Shutdown functions shouldn't get discarded
like exit functions. I'd think the fix for that would be taking
away any __devexit annotation on the shutdown function.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2009-04-29 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 11:59 [PATCH] OMAP OneNAND: add missing __devexit_p wrappers Mika Korhonen
2009-04-29 13:15 ` Adrian Hunter
2009-04-29 13:15 ` Adrian Hunter
2009-04-29 17:55 ` David Brownell [this message]
2009-04-29 17:55 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2009-04-29 11:10 Mika Korhonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904291055.51333.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=adrian.hunter@nokia.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mika.j.korhonen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.