Re: Next April 24: [S390] allmodconfig build failure (trace/events)

[Ingo Molnar <mingo@elte.hu>]

* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Wed, 29 Apr 2009 15:21:39 +0530
> Sachin Sant <sachinp@in.ibm.com> wrote:
> > Heiko Carstens wrote:
> > > On Fri, 24 Apr 2009 09:25:33 +0200
> > > Ingo Molnar <mingo@elte.hu> wrote:
> > >> * Sachin Sant <sachinp@in.ibm.com> wrote:
> > >>> Today's next tree build(s390 allmodconfig) failed with
> > >>>
> > >>> kernel/built-in.o: In function `trace_softirq_entry'
> > >>> include/trace/events/irq.h:42: undefined reference to  
> > >>> `'
> > >>> include/trace/events/irq.h:42: undefined reference to  
> > >>> `__tracepoint_softirq_entry'
> > >>> kernel/built-in.o: In function `trace_softirq_exit':
> > >>> include/trace/events/irq.h:48: undefined reference to  
> > >>> `__tracepoint_softirq_exit'
> > >>> include/trace/events/irq.h:48: undefined reference to  
> > >>> `__tracepoint_softirq_exit'
> > >>>       
> > >> Hm, that's weird - s390 does not build kernel/softirq.o? Hm, it does 
> > >> - softirq.o is an obj-y object.
> > >
> > > s390 does build kernel/softirq.o. However it's anything but obvious to
> > > me how the tracepoint infrastructure works. Too many #ifdefs, #define's
> > > and #undefine's...
> > >
> > > I would expect that struct __tracepoint_softirq_entry somehow gets
> > > defined via one of the TRACE_FORMAT macros, no?
> > Today's next tree also has this failure. Any solution for this problem ?
> 
> Ingo, could you pick up the patch below please?

applied, thanks Heiko!

	Ingo