All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Heiko Carstens <heiko.carstens@de.ibm.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	rostedt@goodmis.org, sachinp@in.ibm.com,
	heiko.carstens@de.ibm.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:tracing/core] tracing: fix build failure on s390
Date: Wed, 29 Apr 2009 12:07:04 GMT	[thread overview]
Message-ID: <tip-fb39b423a214cc3866bbaef78a11af62cae56d31@git.kernel.org> (raw)
In-Reply-To: <20090429135139.5fac79b8@osiris.boeblingen.de.ibm.com>

Commit-ID:  fb39b423a214cc3866bbaef78a11af62cae56d31
Gitweb:     http://git.kernel.org/tip/fb39b423a214cc3866bbaef78a11af62cae56d31
Author:     Heiko Carstens <heiko.carstens@de.ibm.com>
AuthorDate: Wed, 29 Apr 2009 13:51:39 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 29 Apr 2009 14:04:10 +0200

tracing: fix build failure on s390

"tracing: create automated trace defines" causes this compile error on s390,
as reported by Sachin Sant against linux-next:

 kernel/built-in.o: In function `__do_softirq':
 (.text+0x1c680): undefined reference to `__tracepoint_softirq_entry'

This happens because the definitions of the softirq tracepoints were moved
from kernel/softirq.c to kernel/irq/handle.c. Since s390 doesn't support
generic hardirqs handle.c doesn't get compiled and the definitions are
missing.

So move the tracepoints to softirq.c again.

[ Impact: fix build failure on s390 ]

Reported-by: Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: fweisbec@gmail.com
LKML-Reference: <20090429135139.5fac79b8@osiris.boeblingen.de.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/irq/handle.c |    2 --
 kernel/softirq.c    |    2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 37c6363..e68bb5a 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -18,8 +18,6 @@
 #include <linux/rculist.h>
 #include <linux/hash.h>
 #include <linux/bootmem.h>
-
-#define CREATE_TRACE_POINTS
 #include <trace/events/irq.h>
 
 #include "internals.h"
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 7ab9dfd..d4ba347 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -24,6 +24,8 @@
 #include <linux/ftrace.h>
 #include <linux/smp.h>
 #include <linux/tick.h>
+
+#define CREATE_TRACE_POINTS
 #include <trace/events/irq.h>
 
 #include <asm/irq.h>

  parent reply	other threads:[~2009-04-29 12:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24  5:04 linux-next: Tree for April 24 Stephen Rothwell
2009-04-24  6:55 ` Next April 24 : BUG: lock held at task exit time! Sachin Sant
2009-04-24  6:55   ` Sachin Sant
2009-04-24  7:55   ` Stephen Rothwell
2009-04-24  7:55     ` Stephen Rothwell
2009-04-24 11:55     ` Hugh Dickins
2009-04-24 11:55       ` Hugh Dickins
2009-04-24 14:04       ` Al Viro
2009-04-24 14:04         ` Al Viro
2009-04-24 14:11         ` Stephen Rothwell
2009-04-24 14:11           ` Stephen Rothwell
2009-04-24 14:11           ` Stephen Rothwell
2009-04-24  7:12 ` Next April 24: [S390] allmodconfig build failure (trace/events) Sachin Sant
2009-04-24  7:25   ` Ingo Molnar
2009-04-24  8:41     ` Heiko Carstens
2009-04-29  9:51       ` Sachin Sant
2009-04-29 11:51         ` Heiko Carstens
2009-04-29 12:04           ` Ingo Molnar
2009-04-29 12:07           ` tip-bot for Heiko Carstens [this message]
2009-04-29 12:09           ` Steven Rostedt
2009-04-29 12:10           ` [tip:tracing/core] tracing: fix build failure on s390 tip-bot for Heiko Carstens
     [not found] ` <20090424150456.ff35e4ea.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-04-24 17:56   ` linux-next: Tree for April 24 (p54 build error) Randy Dunlap
2009-04-24 17:56     ` Randy Dunlap
2009-04-24 20:47     ` linux-next: Tree for April 24 (p54 build error) (and pull request: wireless-next-2.6 2009-04-24) Christian Lamparter
     [not found]       ` <200904242247.15042.chunkeey-S0/GAf8tV78@public.gmane.org>
2009-04-30 18:30         ` John W. Linville
2009-04-30 18:30           ` John W. Linville
2009-04-26 13:20 ` linux-next: Tree for April 24 Benny Halevy
2009-04-27  4:21   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-fb39b423a214cc3866bbaef78a11af62cae56d31@git.kernel.org \
    --to=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=sachinp@in.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.