Re: [PATCH 4/7] proc: export more page flags in /proc/kpageflags

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>, Matt Mackall <mpm@selenic.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 4/7] proc: export more page flags in /proc/kpageflags
Date: Thu, 7 May 2009 10:20:33 +0800	[thread overview]
Message-ID: <20090507022033.GC12281@localhost> (raw)
In-Reply-To: <20090507110843.2663.A69D9226@jp.fujitsu.com>

On Thu, May 07, 2009 at 10:09:43AM +0800, KOSAKI Motohiro wrote:
> > On Thu, May 07, 2009 at 10:04:31AM +0800, Minchan Kim wrote:
> > > 
> > > Hi, 
> > > 
> > > > +#ifdef CONFIG_MEMORY_FAILURE
> > > > +	u |= kpf_copy_bit(k, KPF_HWPOISON,	PG_hwpoison);
> > > > +#endif
> > > 
> > > Did mmtom merge memory failure feature?
> > 
> > Maybe not yet.. but the #ifdef makes it safe :-)
> 
> Please don't do that.
> dependency of the out of tree code mean "please don't merge me".

OK. I'll keep that in mind for the next take.

WARNING: multiple messages have this Message-ID (diff)

From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>, Matt Mackall <mpm@selenic.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 4/7] proc: export more page flags in /proc/kpageflags
Date: Thu, 7 May 2009 10:20:33 +0800	[thread overview]
Message-ID: <20090507022033.GC12281@localhost> (raw)
In-Reply-To: <20090507110843.2663.A69D9226@jp.fujitsu.com>

On Thu, May 07, 2009 at 10:09:43AM +0800, KOSAKI Motohiro wrote:
> > On Thu, May 07, 2009 at 10:04:31AM +0800, Minchan Kim wrote:
> > > 
> > > Hi, 
> > > 
> > > > +#ifdef CONFIG_MEMORY_FAILURE
> > > > +	u |= kpf_copy_bit(k, KPF_HWPOISON,	PG_hwpoison);
> > > > +#endif
> > > 
> > > Did mmtom merge memory failure feature?
> > 
> > Maybe not yet.. but the #ifdef makes it safe :-)
> 
> Please don't do that.
> dependency of the out of tree code mean "please don't merge me".

OK. I'll keep that in mind for the next take.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2009-05-07  2:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07  1:21 [PATCH 0/7] export more page flags in /proc/kpageflags (take 5) Wu Fengguang
2009-05-07  1:21 ` Wu Fengguang
2009-05-07  1:21 ` [PATCH 1/7] mm: introduce PageHuge() for testing huge/gigantic pages Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-07  1:21 ` [PATCH 2/7] slob: use PG_slab for identifying SLOB pages Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-08 18:24   ` Matt Mackall
2009-05-08 18:24     ` Matt Mackall
2009-05-07  1:21 ` [PATCH 3/7] proc: kpagecount/kpageflags code cleanup Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-08 18:28   ` Matt Mackall
2009-05-08 18:28     ` Matt Mackall
2009-05-07  1:21 ` [PATCH 4/7] proc: export more page flags in /proc/kpageflags Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-07  2:04   ` Minchan Kim
2009-05-07  2:04     ` Minchan Kim
2009-05-07  2:07     ` Wu Fengguang
2009-05-07  2:07       ` Wu Fengguang
2009-05-07  2:09       ` KOSAKI Motohiro
2009-05-07  2:09         ` KOSAKI Motohiro
2009-05-07  2:20         ` Wu Fengguang [this message]
2009-05-07  2:20           ` Wu Fengguang
2009-05-07  2:40   ` Minchan Kim
2009-05-07  2:40     ` Minchan Kim
2009-05-07  2:46     ` Wu Fengguang
2009-05-07  2:46       ` Wu Fengguang
2009-05-07  2:48       ` KOSAKI Motohiro
2009-05-07  2:48         ` KOSAKI Motohiro
2009-05-07  3:05         ` Wu Fengguang
2009-05-07  3:05           ` Wu Fengguang
2009-05-07  1:21 ` [PATCH 5/7] pagemap: document clarifications Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-07  1:21 ` [PATCH 6/7] pagemap: document 9 more exported page flags Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang
2009-05-07  1:21 ` [PATCH 7/7] pagemap: add page-types tool Wu Fengguang
2009-05-07  1:21   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090507022033.GC12281@localhost \
    --to=fengguang.wu@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.