From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Arjan van de Ven <arjan@infradead.org>,
Yinghai Lu <yinghai@kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Stephen Tweedie <sct@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr
Date: Fri, 8 May 2009 13:17:03 +0200 [thread overview]
Message-ID: <20090508111703.GG11596@elte.hu> (raw)
In-Reply-To: <1241730653-4688-6-git-send-email-jeremy@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> +/* DOM0 TODO: Need to fill in the remaining mtrr methods to have full
> + * working userland mtrr support. */
> +static struct mtrr_ops xen_mtrr_ops = {
> + .vendor = X86_VENDOR_UNKNOWN,
> +// .set = xen_set_mtrr,
> +// .get = xen_get_mtrr,
> + .get_free_region = generic_get_free_region,
> +// .validate_add_page = xen_validate_add_page,
> + .have_wrcomb = positive_have_wrcomb,
> + .use_intel_if = 0,
> + .num_var_ranges = xen_num_var_ranges,
> +};
Please dont post patches with ugly TODO items in them.
Also, a more general objection is that /proc/mtrr is a legacy
interface, we dont really want to extend its use. The Xen hypervisor
should get proper PAT support instead ...
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Arjan van de Ven <arjan@infradead.org>,
Yinghai Lu <yinghai@kernel.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Stephen Tweedie <sct@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr
Date: Fri, 8 May 2009 13:17:03 +0200 [thread overview]
Message-ID: <20090508111703.GG11596@elte.hu> (raw)
In-Reply-To: <1241730653-4688-6-git-send-email-jeremy@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> +/* DOM0 TODO: Need to fill in the remaining mtrr methods to have full
> + * working userland mtrr support. */
> +static struct mtrr_ops xen_mtrr_ops = {
> + .vendor = X86_VENDOR_UNKNOWN,
> +// .set = xen_set_mtrr,
> +// .get = xen_get_mtrr,
> + .get_free_region = generic_get_free_region,
> +// .validate_add_page = xen_validate_add_page,
> + .have_wrcomb = positive_have_wrcomb,
> + .use_intel_if = 0,
> + .num_var_ranges = xen_num_var_ranges,
> +};
Please dont post patches with ugly TODO items in them.
Also, a more general objection is that /proc/mtrr is a legacy
interface, we dont really want to extend its use. The Xen hypervisor
should get proper PAT support instead ...
Ingo
next prev parent reply other threads:[~2009-05-08 11:18 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 21:10 [GIT PULL] xen: core dom0 support Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 01/16] xen dom0: Make hvc_xen console work for dom0 Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 02/16] xen dom0: Initialize xenbus " Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 03/16] xen dom0: Set up basic IO permissions " Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 04/16] xen dom0: Add support for the platform_ops hypercall Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-08 11:17 ` Ingo Molnar [this message]
2009-05-08 11:17 ` Ingo Molnar
2009-05-07 21:10 ` [PATCH 06/16] xen: disable PAT Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-08 11:14 ` Ingo Molnar
2009-05-08 11:14 ` Ingo Molnar
2009-05-08 12:38 ` Ian Campbell
2009-05-08 14:50 ` Alan Cox
2009-05-09 8:04 ` [Xen-devel] " Keir Fraser
2009-05-09 8:04 ` Keir Fraser
2009-05-09 18:36 ` [Xen-devel] " H. Peter Anvin
2009-05-10 9:21 ` Keir Fraser
2009-05-10 9:21 ` Keir Fraser
2009-05-10 13:29 ` [Xen-devel] " Alan Cox
2009-05-10 13:29 ` Alan Cox
2009-05-10 17:34 ` [Xen-devel] " Keir Fraser
2009-05-11 9:09 ` Jan Beulich
2009-05-11 9:48 ` Keir Fraser
2009-05-11 18:05 ` Jeremy Fitzhardinge
2009-05-10 17:55 ` [Xen-devel] " H. Peter Anvin
2009-05-11 11:10 ` Ingo Molnar
2009-05-07 21:10 ` [PATCH 07/16] xen/dom0: use _PAGE_IOMAP in ioremap to do machine mappings Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 08/16] xen/dom0: Use host E820 map Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 09/16] xen: implement XENMEM_machphys_mapping Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 10/16] xen: clear reserved bits in l3 entries given in the initial pagetables Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 11/16] xen: allow enable use of VGA console on dom0 Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 12/16] xen/dom0: add XEN_DOM0 config option Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 13/16] x86: make /dev/mem mappings _PAGE_IOMAP Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 14/16] paravirtualize IO permission bitmap Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 15/16] x86: don't need "changed" parameter for set_io_bitmap() Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
2009-05-07 21:10 ` [PATCH 16/16] xen: checkpatch cleanups Jeremy Fitzhardinge
2009-05-07 21:10 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2009-05-12 21:28 [GIT PULL] xen dom0 core changes Jeremy Fitzhardinge
2009-05-12 21:28 ` [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr Jeremy Fitzhardinge
2009-05-12 21:28 ` Jeremy Fitzhardinge
2009-06-02 15:36 ` Thomas Gleixner
2009-06-03 6:34 ` Jeremy Fitzhardinge
2009-06-03 6:34 ` Jeremy Fitzhardinge
2009-05-27 7:15 [GIT PULL REPOST] xen/dom0/core - core Xen dom0 support changes Jeremy Fitzhardinge
2009-05-27 7:15 ` [PATCH 05/16] xen mtrr: Add mtrr_ops support for Xen mtrr Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508111703.GG11596@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.