multipath-tools fixes

multipath-tools fixes

[Mike Snitzer]

Christophe,

Please feel free to pull in the following changes with:
git pull http://people.redhat.com/msnitzer/multipath-tools.git +for-upstream

Mike Snitzer (6):
  multipathd: add error checking to client's process_req
  avoid NULL pointers in discovery code
  do not allow relative path names to be added to the pathvec
  cleanup various MALLOC/REALLOC callers
  fix small issues in cli_handlers
  multipathd: restrict /var/run/multipathd.sock permissions further

 libmultipath/config.c     |    2 +-
 libmultipath/config.h     |    1 +
 libmultipath/dict.c       |    8 ++++----
 libmultipath/discovery.c  |   15 ++++++++++++---
 libmultipath/parser.c     |   15 +++++++++------
 libmultipath/prio.c       |    2 +-
 libmultipath/uevent.c     |    2 +-
 libmultipath/uxsock.c     |    2 ++
 multipathd/cli_handlers.c |    6 +++---
 multipathd/main.c         |    9 +++++++++
 multipathd/uxclnt.c       |   11 ++++++-----
 11 files changed, 49 insertions(+), 24 deletions(-)

Re: multipath-tools fixes

[christophe.varoqui]

Excellent. Let me testify my appreciation of your git handling of this patchset by the promptest pull.

----- Mail Original -----
De: "Mike Snitzer" <snitzer@redhat.com>
À: "christophe varoqui" <christophe.varoqui@free.fr>
Cc: dm-devel@redhat.com
Envoyé: Mercredi 29 Avril 2009 22h10:41 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne
Objet: multipath-tools fixes

Christophe,

Please feel free to pull in the following changes with:
git pull http://people.redhat.com/msnitzer/multipath-tools.git +for-upstream

Mike Snitzer (6):
  multipathd: add error checking to client's process_req
  avoid NULL pointers in discovery code
  do not allow relative path names to be added to the pathvec
  cleanup various MALLOC/REALLOC callers
  fix small issues in cli_handlers
  multipathd: restrict /var/run/multipathd.sock permissions further

 libmultipath/config.c     |    2 +-
 libmultipath/config.h     |    1 +
 libmultipath/dict.c       |    8 ++++----
 libmultipath/discovery.c  |   15 ++++++++++++---
 libmultipath/parser.c     |   15 +++++++++------
 libmultipath/prio.c       |    2 +-
 libmultipath/uevent.c     |    2 +-
 libmultipath/uxsock.c     |    2 ++
 multipathd/cli_handlers.c |    6 +++---
 multipathd/main.c         |    9 +++++++++
 multipathd/uxclnt.c       |   11 ++++++-----
 11 files changed, 49 insertions(+), 24 deletions(-)

Re: multipath-tools fixes

[Kiyoshi Ueda]

Hi Mike,

On 2009/04/30 5:10 +0900, Mike Snitzer wrote:
> Christophe,
> 
> Please feel free to pull in the following changes with:
> git pull http://people.redhat.com/msnitzer/multipath-tools.git +for-upstream
> 
> Mike Snitzer (6):
>   multipathd: add error checking to client's process_req
>   avoid NULL pointers in discovery code
>   do not allow relative path names to be added to the pathvec
>   cleanup various MALLOC/REALLOC callers
>   fix small issues in cli_handlers
>   multipathd: restrict /var/run/multipathd.sock permissions further
> 
>  libmultipath/config.c     |    2 +-
>  libmultipath/config.h     |    1 +
>  libmultipath/dict.c       |    8 ++++----
>  libmultipath/discovery.c  |   15 ++++++++++++---
>  libmultipath/parser.c     |   15 +++++++++------
>  libmultipath/prio.c       |    2 +-
>  libmultipath/uevent.c     |    2 +-
>  libmultipath/uxsock.c     |    2 ++
>  multipathd/cli_handlers.c |    6 +++---
>  multipathd/main.c         |    9 +++++++++
>  multipathd/uxclnt.c       |   11 ++++++-----
>  11 files changed, 49 insertions(+), 24 deletions(-)

I think it's nice if you post actual patches, too, in the future.
Because people can look at your patches easier.

Thanks,
Kiyoshi Ueda

Re: multipath-tools fixes

[Mike Snitzer]

On Fri, May 08 2009 at 12:14am -0400,
Kiyoshi Ueda <k-ueda@ct.jp.nec.com> wrote:

> Hi Mike,
> 
> On 2009/04/30 5:10 +0900, Mike Snitzer wrote:
> > Christophe,
> > 
> > Please feel free to pull in the following changes with:
> > git pull http://people.redhat.com/msnitzer/multipath-tools.git +for-upstream
> > 
> > Mike Snitzer (6):
> >   multipathd: add error checking to client's process_req
> >   avoid NULL pointers in discovery code
> >   do not allow relative path names to be added to the pathvec
> >   cleanup various MALLOC/REALLOC callers
> >   fix small issues in cli_handlers
> >   multipathd: restrict /var/run/multipathd.sock permissions further
> > 
> >  libmultipath/config.c     |    2 +-
> >  libmultipath/config.h     |    1 +
> >  libmultipath/dict.c       |    8 ++++----
> >  libmultipath/discovery.c  |   15 ++++++++++++---
> >  libmultipath/parser.c     |   15 +++++++++------
> >  libmultipath/prio.c       |    2 +-
> >  libmultipath/uevent.c     |    2 +-
> >  libmultipath/uxsock.c     |    2 ++
> >  multipathd/cli_handlers.c |    6 +++---
> >  multipathd/main.c         |    9 +++++++++
> >  multipathd/uxclnt.c       |   11 ++++++-----
> >  11 files changed, 49 insertions(+), 24 deletions(-)
> 
> I think it's nice if you post actual patches, too, in the future.
> Because people can look at your patches easier.

OK, will do.

Regards,
Mike