From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kim Kyuwon <q1.kim@samsung.com>
Cc: Trilok Soni <soni.trilok@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] Input: add MAX7359 key switch controller driver, v2
Date: Sun, 10 May 2009 19:08:36 -0700 [thread overview]
Message-ID: <200905101908.36933.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <4A0784A4.1010703@samsung.com>
Hi KIm,
On Sunday 10 May 2009 18:51:32 Kim Kyuwon wrote:
> Hi Dmitry,
>
> Thank you for streamlining this driver. I confirmed this streamlined driver
> is nicely working on my S3C6410 board and of course I mostly like your
> changes.
Great, thanks for testing.
> But I'm afraid this 'error' variable is not used at the final
> return statement in the probe function.
*blush* Hm, apparently I did not quite finish converting it all to use
"error" ;) I personally like calling such variables "error" if they are
"returned" only in error path and "ret" or "retval" when they are
returned upon both error and successful completion of a function.
I will fold your patch into the original version, thanks a lot.
--
Dmitry
next prev parent reply other threads:[~2009-05-11 2:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 2:09 [PATCH] Input: add MAX7359 key switch controller driver, v2 Kim Kyuwon
2009-05-09 17:27 ` Trilok Soni
2009-05-09 20:01 ` Dmitry Torokhov
2009-05-11 1:51 ` Kim Kyuwon
2009-05-11 2:08 ` Dmitry Torokhov [this message]
2009-05-11 2:34 ` Kim Kyuwon
2009-05-11 2:34 ` Kim Kyuwon
2009-05-11 3:12 ` Dmitry Torokhov
2009-06-19 17:38 ` Trilok Soni
2009-07-13 8:52 ` Trilok Soni
2009-07-13 9:31 ` Dmitry Torokhov
2009-07-14 3:09 ` Kim Kyuwon
2009-07-14 6:28 ` Marek Szyprowski
2009-07-14 8:24 ` Dmitry Torokhov
2009-07-14 8:53 ` Trilok Soni
2009-07-14 9:07 ` Marek Szyprowski
2009-07-14 9:11 ` Trilok Soni
2009-07-14 10:18 ` Marek Szyprowski
2009-07-14 10:23 ` Trilok Soni
2009-07-14 10:23 ` Trilok Soni
2009-07-15 7:15 ` Marek Szyprowski
2009-07-15 7:15 ` Marek Szyprowski
2009-09-16 8:57 ` Dmitry Torokhov
2009-09-16 8:57 ` Dmitry Torokhov
2009-09-18 8:14 ` Joonyoung Shim
2009-09-18 8:14 ` Joonyoung Shim
2009-09-18 16:39 ` Dmitry Torokhov
2009-09-19 0:07 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905101908.36933.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=q1.kim@samsung.com \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.