From: Al Viro <viro@ZenIV.linux.org.uk>
To: hooanon05@yahoo.co.jp
Cc: linux-kernel@vger.kernel.org
Subject: Re: Q. Switch open_exec() and sys_uselib() to do_open_filp()
Date: Mon, 11 May 2009 02:28:28 +0100 [thread overview]
Message-ID: <20090511012828.GH8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <29926.1242003317@jrobl>
On Mon, May 11, 2009 at 09:55:17AM +0900, hooanon05@yahoo.co.jp wrote:
>
> By the commit 6e8341a11eb21826b7192d0bb88cb5b44900a9af
> "Switch open_exec() and sys_uselib() to do_open_filp()",
> FMODE_EXEC flag is passed to struct file. I have no objection nor
> question about that.
>
> But it is set to file->f_flags instead of f_mode.
> Is this intended behaviour?
It is previously existing behaviour. Check what path_lookup_open() does
and how had it used to be called.
And no, very little about intents makes any sense, including that part.
Call graph of the entire lookup-and-open-related machinery least of all.
So we have to untangle that mound of mating tapeworms, one by one ;-/
next prev parent reply other threads:[~2009-05-11 1:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 0:55 Q. Switch open_exec() and sys_uselib() to do_open_filp() hooanon05
2009-05-11 1:28 ` Al Viro [this message]
2009-05-11 2:46 ` hooanon05
2009-05-11 4:00 ` Al Viro
2009-05-11 5:20 ` hooanon05
2009-05-11 6:52 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511012828.GH8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.