From: hooanon05@yahoo.co.jp
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Q. Switch open_exec() and sys_uselib() to do_open_filp()
Date: Mon, 11 May 2009 14:20:09 +0900 [thread overview]
Message-ID: <7134.1242019209@jrobl> (raw)
In-Reply-To: <20090511040019.GI8633@ZenIV.linux.org.uk>
Al Viro:
> Nope. It ended up in nd->intent.open.flags due to path_lookup_open().
Yes.
> Then lookup_instantiate_filp() from a filesystem that might care about
> intents did
> nd->intent.open.file = __dentry_open(dget(dentry), mntget(nd->mnt),
> nd->intent.open.flags - 1,
> nd->intent.open.file,
> open);
> and nameidata_to_filp() ended up picking nd->intent.open.file.
FS supporting lookup_instantiate_filp() is rare, isn't it?
Simple grep told me it is called by fuse, nfsv4, cifs, and 9p only.
In other FS, FMODE_EXEC was dropped since nameidata_to_filp() (from
open_exec() directly) doesn't pick intent.open.flags up.
Anyway, I could confirm that setting FMODE_EXEC to f_flags is intended.
Thank you for your quick responces.
J. R. Okajima
next prev parent reply other threads:[~2009-05-11 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 0:55 Q. Switch open_exec() and sys_uselib() to do_open_filp() hooanon05
2009-05-11 1:28 ` Al Viro
2009-05-11 2:46 ` hooanon05
2009-05-11 4:00 ` Al Viro
2009-05-11 5:20 ` hooanon05 [this message]
2009-05-11 6:52 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7134.1242019209@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.