All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: Theodore Tso <tytso@mit.edu>,
	Matthew Wilcox <willy@linux.intel.com>,
	Ric Wheeler <rwheeler@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: Is TRIM/DISCARD going to be a performance problem?
Date: Mon, 11 May 2009 12:18:15 +0200	[thread overview]
Message-ID: <20090511101815.GR4694@kernel.dk> (raw)
In-Reply-To: <20090511100624.GB6585@logfs.org>

On Mon, May 11 2009, Jörn Engel wrote:
> On Mon, 11 May 2009 04:37:54 -0400, Theodore Tso wrote:
> > 
> > Well, no one has actually implemented the low-level TRIM support yet;
> 
> Iirc dwmw2 did so for some of the FTL drivers.  More a curiosity than a
> useful device, though.
> 
> > Well, no, Matthew's changes didn't do any of that, I suspect because
> > most SSD's, including X25-M, are expected to have a granularity size
> > of 1 block.  It's the crazy people in the SCSI standards world who've
> > been pushing for granlarity sizes in the 1-4 megabyte range; as I
> > understand things, the granularity issue was not going to be a problem
> > for the ATA TRIM command.
> 
> I am not sure about this part.  So far Intel has been the only party to
> release any information about their dark-grey box.  All other boxes are
> still solid black.  And until I'm told otherwise I'd consider them to be
> stupid devices that use erase block size as trim granularity.
> 
> Given the total lack of information, your guess is as good as mine,
> though.
> 
> > As far as thinking that the proposal is ludicrous --- what precisely
> > did you find ludicrous about it?
> 
> Mainly the idea that discard requests should act as barriers and instead
> of fixing that, you propose a lot of complexity to work around it.

But the command is effectively a barrier at the device level anyway,
since you need to drain the hardware queue before issuing.

> > The only problem with SSD's is the people who designed the ATA TRIM
> > command requires us to completely drian the I/O queue before issuing
> > it.  Because of this incompetence, we need to be a bit more careful
> > about how we issue them.
> 
> And this bit that I wasn't aware of.  Such a requirement in the standard
> is a trainwreck indeed.

Precisely, but that's how basically anything works with SATA NCQ, only
read/write dma commands may be queued. Anything else requires an idle
drive before issue.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-05-11 10:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09 21:14 Is TRIM/DISCARD going to be a performance problem? Theodore Ts'o
2009-05-10 16:53 ` Jörn Engel
2009-05-11  8:37   ` Theodore Tso
2009-05-11 10:06     ` Jörn Engel
2009-05-11 10:18       ` Jens Axboe [this message]
2009-05-11 15:43         ` Jeff Garzik
2009-05-11 11:27       ` Theodore Tso
2009-05-11 12:09         ` Theodore Tso
2009-05-11 13:10           ` Greg Freemyer
2009-05-11 13:39             ` Matthew Wilcox
2009-05-11 14:27             ` Theodore Tso
2009-05-11 14:29               ` Ric Wheeler
2009-05-11 14:50                 ` Theodore Tso
2009-05-11 14:58                   ` Ric Wheeler
2009-05-11 15:00                   ` Matthew Wilcox
2009-05-11 18:47                     ` Greg Freemyer
2009-05-11 19:22                       ` Andreas Dilger
2009-05-11 23:38                       ` Neil Brown
2009-05-12 13:28                         ` Greg Freemyer
2009-05-11 13:15           ` Ric Wheeler
2010-04-24 17:11           ` Phillip Susi
2009-05-11 12:43         ` Jörn Engel
2009-05-11 12:48           ` Matthew Wilcox
     [not found]             ` <f3177b9e0905111433i40e41c90r920d7ccf36442ffd@mail.gmail.com>
2009-05-11 22:03               ` Chris Worley
2009-05-11 16:30       ` Chris Worley
2009-05-11  8:12 ` Jens Axboe
2009-05-11  8:41   ` Theodore Tso
2009-05-11  8:49     ` Jens Axboe
2009-05-11 17:18     ` Chris Mason
2009-05-11 18:43       ` Matthew Wilcox
2009-05-11 18:53         ` Chris Mason
2009-05-11 19:19           ` Theodore Tso
2009-05-29 10:52         ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090511101815.GR4694@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=joern@logfs.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rwheeler@redhat.com \
    --cc=tytso@mit.edu \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.