From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: David Rientjes <rientjes@google.com>,
Jack Steiner <steiner@sgi.com>, Yinghai Lu <yinghai@kernel.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86: fix node_possible_map logic -v2
Date: Tue, 12 May 2009 09:15:31 +0200 [thread overview]
Message-ID: <20090512071531.GF19296@one.firstfloor.org> (raw)
In-Reply-To: <4A0894A5.9000209@zytor.com>
> Should it? It seems to me that CPUs 0-1 should be antipreferentially
> scheduled,
You could do that, but the question is if it matters. It would
only make a difference on systems which are not fully loaded,
and it's unclear how much.
And at some point you need to use these cores anyways; usually it's much
worse to not use a CPU and overload others than to use it with slower memory.
Is it worth adding a lot of fixes all over hte kernel? Not clear
to me.
Also it's a obscure situation and it affects a lot of code, so you
would likely have to continuously fight with regressions as Jack
has discovered.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-05-12 7:10 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 6:45 [PATCH 1/3] x86: remove MEMORY_HOTPLUG_RESERVE related code Yinghai Lu
2009-05-09 6:48 ` [PATCH 2/3] x86: add numa_move_cpus_to_node Yinghai Lu
2009-05-09 7:05 ` Justin P. Mattock
2009-05-12 1:27 ` Christoph Lameter
2009-05-11 21:53 ` Yinghai Lu
2009-05-12 20:59 ` Christoph Lameter
2009-05-12 17:16 ` Yinghai Lu
2009-05-12 21:21 ` Christoph Lameter
2009-05-13 5:39 ` Yinghai Lu
2009-05-14 19:34 ` Christoph Lameter
2009-05-14 20:58 ` Yinghai Lu
2009-05-09 6:50 ` [PATCH 3/3] x86: fix node_possible_map logic -v2 Yinghai Lu
2009-05-11 17:53 ` Jack Steiner
2009-05-11 19:15 ` Yinghai Lu
2009-05-11 19:36 ` Yinghai Lu
2009-05-11 19:27 ` David Rientjes
2009-05-11 21:12 ` H. Peter Anvin
2009-05-11 21:26 ` Alan Cox
2009-05-11 22:25 ` David Rientjes
2009-05-12 15:06 ` Jack Steiner
2009-05-12 15:10 ` Yinghai Lu
2009-05-12 16:16 ` Jack Steiner
2009-05-12 16:40 ` Yinghai Lu
2009-05-12 18:03 ` Jack Steiner
2009-05-12 21:31 ` Yinghai Lu
2009-05-12 21:58 ` Jack Steiner
2009-05-12 23:13 ` Yinghai Lu
2009-05-12 23:26 ` Yinghai Lu
2009-05-12 15:43 ` Andi Kleen
2009-05-13 1:34 ` [PATCH] x86: fix system without memory on node0 Yinghai Lu
2009-05-13 8:00 ` Andi Kleen
2009-05-13 15:58 ` Yinghai Lu
2009-05-13 13:35 ` Ingo Molnar
2009-05-13 16:52 ` Jack Steiner
2009-05-13 17:43 ` Yinghai Lu
2009-05-13 18:08 ` Yinghai Lu
2009-05-12 7:15 ` Andi Kleen [this message]
2009-05-11 21:33 ` [PATCH 3/3] x86: fix node_possible_map logic -v2 Jack Steiner
2009-05-11 22:56 ` David Rientjes
2009-05-11 23:00 ` Yinghai Lu
2009-05-12 7:09 ` Andi Kleen
2009-05-12 1:02 ` [PATCH 1/3] x86: remove MEMORY_HOTPLUG_RESERVE related code Christoph Lameter
2009-05-12 11:16 ` Mel Gorman
2009-05-13 5:29 ` Yinghai Lu
2009-05-13 9:55 ` Mel Gorman
2009-05-13 6:13 ` [PATCH] x86: remove MEMORY_HOTPLUG_RESERVE related code -v2 Yinghai Lu
2009-05-13 14:59 ` Mel Gorman
2009-05-14 16:38 ` [PATCH 1/5] " Yinghai Lu
2009-05-14 16:40 ` [PATCH 2/5] x86: add numa_move_cpus_to_node Yinghai Lu
2009-05-14 16:41 ` [PATCH 3/5] x86: fix node_possible_map logic -v2 Yinghai Lu
2009-05-18 7:40 ` [tip:x86/mm] x86, mm: Fix node_possible_map logic tip-bot for Yinghai Lu
2009-05-14 16:42 ` [PATCH 4/5] x86: fix system without memory on node0 -v2 Yinghai Lu
2009-05-18 7:40 ` [tip:x86/mm] x86: fix system without memory on node0 tip-bot for Yinghai Lu
2009-05-14 16:43 ` [PATCH 5/5] mm: clear N_HIGH_MEMORY map before se set it again -v2 Yinghai Lu
2009-05-14 16:54 ` Andrew Morton
2009-05-14 17:05 ` Yinghai Lu
2009-05-14 17:25 ` Andrew Morton
2009-05-14 17:34 ` Yinghai Lu
2009-05-14 19:44 ` Christoph Lameter
2009-06-04 5:16 ` [RESEND PATCH] " Yinghai Lu
2009-06-04 16:38 ` Christoph Lameter
2009-06-04 16:48 ` Yinghai Lu
2009-06-04 17:11 ` Christoph Lameter
2009-06-04 17:26 ` [PATCH] mm: clear N_HIGH_MEMORY map before se set it again -v4 Yinghai Lu
[not found] ` <4A2803D1.4070001-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-19 6:42 ` Nathan Lynch
2009-06-19 6:42 ` Nathan Lynch
2009-06-19 8:18 ` Yinghai Lu
2009-06-19 8:43 ` Nathan Lynch
2009-06-19 16:16 ` Yinghai Lu
[not found] ` <m3prd0havh.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-19 16:16 ` Yinghai Lu
2009-06-20 23:43 ` Yinghai Lu
2009-06-20 23:43 ` Yinghai Lu
2009-06-22 4:39 ` Nathan Lynch
2009-06-22 15:38 ` [PATCH] x86: only clear node_states for 64bit Yinghai Lu
2009-06-26 20:54 ` Andrew Morton
2009-06-26 21:09 ` Yinghai Lu
[not found] ` <4A4538FE.2090101-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-27 17:17 ` Ingo Molnar
2009-06-27 17:17 ` Ingo Molnar
[not found] ` <20090627171714.GD21595-X9Un+BFzKDI@public.gmane.org>
2009-06-27 20:40 ` Yinghai Lu
2009-06-27 20:40 ` Yinghai Lu
[not found] ` <4A4683B2.106-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-29 7:39 ` Yinghai Lu
2009-06-29 7:39 ` Yinghai Lu
[not found] ` <20090626135428.d8f88a70.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2009-06-26 21:09 ` Yinghai Lu
[not found] ` <4A3FA58A.3010909-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-26 20:54 ` Andrew Morton
[not found] ` <m3my807ug3.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-22 15:38 ` Yinghai Lu
[not found] ` <4A3D7419.8040305-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-22 4:39 ` [PATCH] mm: clear N_HIGH_MEMORY map before se set it again -v4 Nathan Lynch
[not found] ` <4A3B49BA.40100-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-06-19 8:43 ` Nathan Lynch
[not found] ` <m3bpokiv0u.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-19 8:18 ` Yinghai Lu
2009-05-18 7:39 ` [tip:x86/mm] mm, x86: remove MEMORY_HOTPLUG_RESERVE related code tip-bot for Yinghai Lu
[not found] ` <20090511095022.GA23121@elte.hu>
[not found] ` <20090511163158.c4e4d334.akpm@linux-foundation.org>
[not found] ` <20090512090704.GC18004@elte.hu>
[not found] ` <4A0A6700.3070100@kernel.org>
[not found] ` <20090513133635.GB7384@elte.hu>
[not found] ` <4A0AFA6E.5050200@kernel.org>
[not found] ` <20090515173521.GA29647@elte.hu>
2009-05-15 21:38 ` tip: patches in git for irq and numa Yinghai Lu
2009-05-18 7:29 ` Ingo Molnar
2009-05-18 13:50 ` Peter Zijlstra
2009-05-18 13:56 ` Ingo Molnar
2009-05-18 15:03 ` Yinghai Lu
2009-05-18 15:09 ` Ingo Molnar
2009-05-18 15:11 ` Peter Zijlstra
2009-05-18 17:23 ` Yinghai Lu
2009-05-19 9:37 ` Ingo Molnar
2009-05-19 10:31 ` Peter Zijlstra
2009-05-19 12:26 ` Ingo Molnar
2009-05-19 9:39 ` [tip:irq/numa] x86, io-apic: Don't mark pin_programmed early tip-bot for Yinghai Lu
2009-05-19 12:30 ` tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512071531.GF19296@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.