From: Andrew Morton <akpm@linux-foundation.org>
To: Li Yang <leoli@freescale.com>
Cc: zw@zh-kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
leoli@freescale.com, davem@davemloft.net
Subject: Re: [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block
Date: Tue, 12 May 2009 15:05:52 -0700 [thread overview]
Message-ID: <20090512150552.a98dca64.akpm@linux-foundation.org> (raw)
In-Reply-To: <1242117363-14949-3-git-send-email-leoli@freescale.com>
On Tue, 12 May 2009 16:36:00 +0800
Li Yang <leoli@freescale.com> wrote:
> + align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1);
> +
> + /* Align the size */
> + if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {
__ilog2() and _ALIGN_DOWN() are powerpc-specific functions. It would
be preferable to use more general helpers if possible. ALIGN() and ilog2()
might suit here.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Li Yang <leoli@freescale.com>
Cc: galak@kernel.crashing.org, davem@davemloft.net,
mporter@kernel.crashing.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
leoli@freescale.com, zw@zh-kernel.org
Subject: Re: [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block
Date: Tue, 12 May 2009 15:05:52 -0700 [thread overview]
Message-ID: <20090512150552.a98dca64.akpm@linux-foundation.org> (raw)
In-Reply-To: <1242117363-14949-3-git-send-email-leoli@freescale.com>
On Tue, 12 May 2009 16:36:00 +0800
Li Yang <leoli@freescale.com> wrote:
> + align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1);
> +
> + /* Align the size */
> + if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {
__ilog2() and _ALIGN_DOWN() are powerpc-specific functions. It would
be preferable to use more general helpers if possible. ALIGN() and ilog2()
might suit here.
next prev parent reply other threads:[~2009-05-12 22:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 8:35 [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access Li Yang
2009-05-12 8:35 ` Li Yang
2009-05-12 8:35 ` [PATCH 2/6] powerpc/fsl_rio: use LAW address from device tree Li Yang
2009-05-12 8:35 ` Li Yang
2009-05-12 8:36 ` [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block Li Yang
2009-05-12 8:36 ` Li Yang
2009-05-12 8:36 ` [PATCH 4/6] rionet: add memory access to simulated Ethernet over rapidio Li Yang
2009-05-12 8:36 ` Li Yang
2009-05-12 8:36 ` [PATCH 5/6] rio: warn_unused_result warnings fix Li Yang
2009-05-12 8:36 ` Li Yang
2009-05-12 8:36 ` [PATCH 6/6] rio: fix section mismatch Li Yang
2009-05-12 8:36 ` Li Yang
2009-05-13 22:08 ` Kumar Gala
2009-05-13 22:08 ` Kumar Gala
2009-05-12 22:11 ` [PATCH 5/6] rio: warn_unused_result warnings fix Andrew Morton
2009-05-12 22:11 ` Andrew Morton
2009-06-11 4:34 ` Kumar Gala
2009-06-11 4:34 ` Kumar Gala
2009-05-12 22:10 ` [PATCH 4/6] rionet: add memory access to simulated Ethernet over rapidio Andrew Morton
2009-05-12 22:10 ` Andrew Morton
2009-05-12 22:05 ` Andrew Morton [this message]
2009-05-12 22:05 ` [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block Andrew Morton
2009-05-21 10:43 ` Li Yang
2009-05-21 10:43 ` Li Yang
2009-05-21 10:43 ` Li Yang
2009-05-13 22:08 ` [PATCH 2/6] powerpc/fsl_rio: use LAW address from device tree Kumar Gala
2009-05-13 22:08 ` Kumar Gala
2009-06-11 4:13 ` [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access Kumar Gala
2009-06-11 4:13 ` Kumar Gala
2009-06-11 9:47 ` Li Yang-R58472
2009-06-11 9:47 ` Li Yang-R58472
2009-06-11 13:32 ` Kumar Gala
2009-06-11 13:32 ` Kumar Gala
2009-06-12 13:27 ` Li Yang
2009-06-12 13:27 ` Li Yang
2009-06-12 13:27 ` Li Yang
2009-06-12 13:58 ` Kumar Gala
2009-06-12 13:58 ` Kumar Gala
2009-06-15 10:38 ` Li Yang
2009-06-15 10:38 ` Li Yang
2009-06-15 10:38 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512150552.a98dca64.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.