All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Kalle Valo <kalle.valo@iki.fi>, Roel Kluin <roel.kluin@gmail.com>,
	linux-omap@vger.kernel.org,
	Jarkko Nikula <jarkko.nikula@nokia.com>
Subject: [PATCH 3/8] ARM: OMAP2: Fix tusb6010 init error and compilation warning
Date: Thu, 14 May 2009 10:45:54 -0700	[thread overview]
Message-ID: <20090514174554.12080.63896.stgit@localhost> (raw)
In-Reply-To: <20090514174100.12080.9736.stgit@localhost>

From: Jarkko Nikula <jarkko.nikula@nokia.com>

Fix "tusb6010 init error 5, -19" and compilation warning from function
tusb6010_platform_retime "warning: 'sysclk_ps' is used uninitialized in this
function".

I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant to test
for zero fclk_ps instead of sysclk_ps.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: Roel Kluin <roel.kluin@gmail.com>
Tested-by: Kalle Valo <kalle.valo@iki.fi>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/usb-tusb6010.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
index 8df55f4..8622c24 100644
--- a/arch/arm/mach-omap2/usb-tusb6010.c
+++ b/arch/arm/mach-omap2/usb-tusb6010.c
@@ -187,7 +187,7 @@ int tusb6010_platform_retime(unsigned is_refclk)
 	unsigned	sysclk_ps;
 	int		status;
 
-	if (!refclk_psec || sysclk_ps == 0)
+	if (!refclk_psec || fclk_ps == 0)
 		return -ENODEV;
 
 	sysclk_ps = is_refclk ? refclk_psec : TUSB6010_OSCCLK_60;


  parent reply	other threads:[~2009-05-14 17:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 17:41 [PATCH 0/8] Omap fixes for 2.6.30-rc5 Tony Lindgren
2009-05-14 17:43 ` [PATCH 1/8] ARM: OMAP: Fix printing of reserved memory for frambuffer Tony Lindgren
2009-05-14 17:44 ` [PATCH 2/8] ARM: OMAP: GPIO de-bounce clocks don't affect module idle state Tony Lindgren
2009-05-14 17:45 ` Tony Lindgren [this message]
2009-05-14 17:47 ` [PATCH 4/8] ARM: OMAP2: Fix SPI driver failure on 2420 when running multi-omap config Tony Lindgren
2009-05-14 17:48 ` [PATCH 5/8] ARM: OMAP2/3: Add name for musb clocks Tony Lindgren
2009-05-14 17:49 ` [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi Tony Lindgren
2009-05-14 19:03   ` Krzysztof Helt
2009-05-14 20:28     ` Tony Lindgren
2009-05-16  9:06       ` Russell King - ARM Linux
2009-05-16 15:25         ` Tony Lindgren
2009-05-16 16:22           ` Russell King - ARM Linux
2009-05-16 18:02             ` Tony Lindgren
2009-05-14 17:51 ` [PATCH 7/8] ARM: OMAP3: Fix number of GPIO lines for 34xx Tony Lindgren
2009-05-15  2:29   ` Gadiyar, Anand
2009-05-15 15:07     ` Tony Lindgren
2009-05-14 17:52 ` [PATCH 8/8] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define Tony Lindgren
2009-05-15 22:41 ` git pull request for omap-fixes (Re: [PATCH 0/8] Omap fixes for 2.6.30-rc5) Tony Lindgren
2009-05-16 15:41   ` git pull request for omap-fixes, v2 " Tony Lindgren
2009-05-16 18:05     ` git pull request for omap-fixes, v3 " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514174554.12080.63896.stgit@localhost \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=kalle.valo@iki.fi \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.