All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
	Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org,
	Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Subject: [PATCH 8/8] ARM: OMAP3: Fix HW SAVEANDRESTORE shift define
Date: Thu, 14 May 2009 10:52:40 -0700	[thread overview]
Message-ID: <20090514175240.12080.19021.stgit@localhost> (raw)
In-Reply-To: <20090514174100.12080.9736.stgit@localhost>

From: Kalle Jokiniemi <kalle.jokiniemi@digia.com>

The OMAP3430ES2_SAVEANDRESTORE_SHIFT macro is used
by powerdomain code in
"1 << OMAP3430ES2_SAVEANDRESTORE_SHIFT" manner, but
the definition was also (1 << 4), meaning we actually
modified bit 16. So the definition needs to be 4.

This fixes also a cold reset HW bug in OMAP3430 ES3.x
where some of the efuse bits are not isolated during
wake-up from off mode. This can cause randomish
cold resets with off mode. Enabling the USBTLL hardware
SAVEANDRESTORE causes the core power up assert to be
delayed in a way that we will not get faulty values
when boot ROM is reading the unisolated registers.

Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
Acked-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/prm-regbits-34xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
index c6a7940..9fd03a2 100644
--- a/arch/arm/mach-omap2/prm-regbits-34xx.h
+++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
@@ -409,7 +409,7 @@
 /* PM_PREPWSTST_CAM specific bits */
 
 /* PM_PWSTCTRL_USBHOST specific bits */
-#define OMAP3430ES2_SAVEANDRESTORE_SHIFT		(1 << 4)
+#define OMAP3430ES2_SAVEANDRESTORE_SHIFT		4
 
 /* RM_RSTST_PER specific bits */
 


  parent reply	other threads:[~2009-05-14 17:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 17:41 [PATCH 0/8] Omap fixes for 2.6.30-rc5 Tony Lindgren
2009-05-14 17:43 ` [PATCH 1/8] ARM: OMAP: Fix printing of reserved memory for frambuffer Tony Lindgren
2009-05-14 17:44 ` [PATCH 2/8] ARM: OMAP: GPIO de-bounce clocks don't affect module idle state Tony Lindgren
2009-05-14 17:45 ` [PATCH 3/8] ARM: OMAP2: Fix tusb6010 init error and compilation warning Tony Lindgren
2009-05-14 17:47 ` [PATCH 4/8] ARM: OMAP2: Fix SPI driver failure on 2420 when running multi-omap config Tony Lindgren
2009-05-14 17:48 ` [PATCH 5/8] ARM: OMAP2/3: Add name for musb clocks Tony Lindgren
2009-05-14 17:49 ` [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi Tony Lindgren
2009-05-14 19:03   ` Krzysztof Helt
2009-05-14 20:28     ` Tony Lindgren
2009-05-16  9:06       ` Russell King - ARM Linux
2009-05-16 15:25         ` Tony Lindgren
2009-05-16 16:22           ` Russell King - ARM Linux
2009-05-16 18:02             ` Tony Lindgren
2009-05-14 17:51 ` [PATCH 7/8] ARM: OMAP3: Fix number of GPIO lines for 34xx Tony Lindgren
2009-05-15  2:29   ` Gadiyar, Anand
2009-05-15 15:07     ` Tony Lindgren
2009-05-14 17:52 ` Tony Lindgren [this message]
2009-05-15 22:41 ` git pull request for omap-fixes (Re: [PATCH 0/8] Omap fixes for 2.6.30-rc5) Tony Lindgren
2009-05-16 15:41   ` git pull request for omap-fixes, v2 " Tony Lindgren
2009-05-16 18:05     ` git pull request for omap-fixes, v3 " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514175240.12080.19021.stgit@localhost \
    --to=tony@atomide.com \
    --cc=kalle.jokiniemi@digia.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.