All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] kvm: discard masking checking when initial MSI-X entries
Date: Fri, 15 May 2009 09:59:15 +0800	[thread overview]
Message-ID: <200905150959.15615.sheng@linux.intel.com> (raw)
In-Reply-To: <1241494915-14517-1-git-send-email-sheng@linux.intel.com>

On Tuesday 05 May 2009 11:41:55 Sheng Yang wrote:
> This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
> otherwise QEmu only counts the MSI-X entries, but won't fill it...
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  hw/device-assignment.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 0a5f850..bee0bd8 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice
> *pci_dev) if (entries_nr >= msix_nr.entry_nr)
>              break;
>          memcpy(&msg_ctrl, va + i * 16 + 12, 4);
> -        if (msg_ctrl & 0x1)
> -            continue;
>          memcpy(&msg_data, va + i * 16 + 8, 4);
>          if (msg_data == 0)
>              continue;

Avi?

-- 
regards
Yang, Sheng

  reply	other threads:[~2009-05-15  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  3:41 [PATCH] kvm: discard masking checking when initial MSI-X entries Sheng Yang
2009-05-15  1:59 ` Sheng Yang [this message]
2009-05-18  8:27 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905150959.15615.sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.