From: Wu Fengguang <fengguang.wu@intel.com>
To: MinChan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V3
Date: Mon, 18 May 2009 10:34:04 +0800 [thread overview]
Message-ID: <20090518023404.GB5869@localhost> (raw)
In-Reply-To: <20090514231555.f52c81eb.minchan.kim@gmail.com>
On Thu, May 14, 2009 at 11:15:55PM +0900, MinChan Kim wrote:
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2f9d555..621708f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone,
> * Even if we did not try to evict anon pages at all, we want to
> * rebalance the anon lru active/inactive ratio.
> */
> - if (inactive_anon_is_low(zone, sc))
> + if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)
> shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
There's another "if (inactive_anon_is_low) shrink_active_list;"
occurrence to be fixed in balance_pgdat()? Otherwise:
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: MinChan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V3
Date: Mon, 18 May 2009 10:34:04 +0800 [thread overview]
Message-ID: <20090518023404.GB5869@localhost> (raw)
In-Reply-To: <20090514231555.f52c81eb.minchan.kim@gmail.com>
On Thu, May 14, 2009 at 11:15:55PM +0900, MinChan Kim wrote:
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2f9d555..621708f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone,
> * Even if we did not try to evict anon pages at all, we want to
> * rebalance the anon lru active/inactive ratio.
> */
> - if (inactive_anon_is_low(zone, sc))
> + if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0)
> shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0);
There's another "if (inactive_anon_is_low) shrink_active_list;"
occurrence to be fixed in balance_pgdat()? Otherwise:
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-18 2:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 14:15 [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V3 MinChan Kim
2009-05-14 14:15 ` MinChan Kim
2009-05-14 14:27 ` KOSAKI Motohiro
2009-05-14 14:27 ` KOSAKI Motohiro
2009-05-14 14:39 ` Minchan Kim
2009-05-14 14:39 ` Minchan Kim
2009-05-14 14:54 ` KOSAKI Motohiro
2009-05-14 14:54 ` KOSAKI Motohiro
2009-05-14 16:22 ` Johannes Weiner
2009-05-14 16:22 ` Johannes Weiner
2009-05-15 1:28 ` Minchan Kim
2009-05-15 1:28 ` Minchan Kim
2009-05-14 15:25 ` Rik van Riel
2009-05-14 15:25 ` Rik van Riel
2009-05-14 16:30 ` Andrew Morton
2009-05-14 16:30 ` Andrew Morton
2009-05-14 17:26 ` Rik van Riel
2009-05-14 17:26 ` Rik van Riel
2009-05-18 2:34 ` Wu Fengguang [this message]
2009-05-18 2:34 ` Wu Fengguang
2009-05-18 2:40 ` Minchan Kim
2009-05-18 2:40 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518023404.GB5869@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.