[PATCH 0/1] ASoC: TWL4030: fix analog right microphone path

[PATCH 0/1] ASoC: TWL4030: fix analog right microphone path

[Peter Ujfalusi]

Hello,

Here is the fix for AUXR recording that Anuj reported.
Bit 2 is selecting the AUXR input in the ANAMICR register and not bit 1.

---
Peter Ujfalusi (1):
  ASoC: TWL4030: Fix Analog capture path for AUXR

 sound/soc/codecs/twl4030.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/1] ASoC: TWL4030: Fix Analog capture path for AUXR

[Peter Ujfalusi]

AUXR is selected by bit 2 and not by bit 1 in the ANAMICR register.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/twl4030.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index afe7879..70d9500 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -438,7 +438,7 @@ static const struct snd_kcontrol_new twl4030_dapm_analoglmic_controls[] = {
 /* Right analog microphone selection */
 static const struct snd_kcontrol_new twl4030_dapm_analogrmic_controls[] = {
 	SOC_DAPM_SINGLE("Sub mic", TWL4030_REG_ANAMICR, 0, 1, 0),
-	SOC_DAPM_SINGLE("AUXR", TWL4030_REG_ANAMICR, 1, 1, 0),
+	SOC_DAPM_SINGLE("AUXR", TWL4030_REG_ANAMICR, 2, 1, 0),
 };
 
 /* TX1 L/R Analog/Digital microphone selection */
-- 
1.6.3

Re: [PATCH 1/1] ASoC: TWL4030: Fix Analog capture path for AUXR

[Mark Brown]

On Tue, May 19, 2009 at 10:51:03AM +0300, Peter Ujfalusi wrote:
> AUXR is selected by bit 2 and not by bit 1 in the ANAMICR register.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Applied, thanks.

Re: [PATCH 1/1] ASoC: TWL4030: Fix Analog capture path for AUXR

[Aggarwal, Anuj]

What should be the quickest way to merge all the ASoC patches which have come after my 2.6.29-rc3 release? I have a found a solution for my tuck noise problem now but cannot apply the patch as it is, because the tip has moved ahead from my baseline by several commits. I cannot move my baseline so have to pull only sound/soc related patches.

Is there any repository where I will find only asoc related patches? Or what should be the ideal way to handle this?

Thanks and Regards,
Anuj Aggarwal

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Tuesday, May 19, 2009 2:20 PM
> To: Peter Ujfalusi
> Cc: alsa-devel@alsa-project.org; sakoman@gmail.com; Aggarwal, Anuj
> Subject: Re: [PATCH 1/1] ASoC: TWL4030: Fix Analog capture path for AUXR
> 
> On Tue, May 19, 2009 at 10:51:03AM +0300, Peter Ujfalusi wrote:
> > AUXR is selected by bit 2 and not by bit 1 in the ANAMICR register.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> 
> Applied, thanks.

Re: [PATCH 1/1] ASoC: TWL4030: Fix Analog capture path for AUXR

[Mark Brown]

On Tue, May 19, 2009 at 03:18:09PM +0530, Aggarwal, Anuj wrote:
> What should be the quickest way to merge all the ASoC patches which have come after my 2.6.29-rc3 release? I have a found a solution for my tuck noise problem now but cannot apply the patch as it is, because the tip has moved ahead from my baseline by several commits. I cannot move my baseline so have to pull only sound/soc related patches.

> Is there any repository where I will find only asoc related patches? Or what should be the ideal way to handle this?

You want the topic/asoc branch of:

git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

That'll have some additional stuff from mainline due to some merge ups
of ALSA-wide stuff but it should all be safe given that it's targetting
2.6.30.