From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools lvconvert.c
Date: 19 May 2009 10:27:47 -0000 [thread overview]
Message-ID: <20090519102747.21668.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-05-19 10:27:47
Modified files:
tools : lvconvert.c
Log message:
Fix lvconvert check for multiple-segment mirrors (mornfall)
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.74&r2=1.75
--- LVM2/tools/lvconvert.c 2009/05/19 10:12:41 1.74
+++ LVM2/tools/lvconvert.c 2009/05/19 10:27:47 1.75
@@ -542,11 +542,10 @@
}
/*
- * FIXME This check used to precede mirror->mirror conversion
- * but didn't affect mirror->linear or linear->mirror. I do
- * not understand what is its intention, in fact.
+ * For the most part, we cannot handle multi-segment mirrors. Bail out
+ * early if we have encountered one.
*/
- if (dm_list_size(&lv->segments) != 1) {
+ if ((lv->status & MIRRORED) && dm_list_size(&lv->segments) != 1) {
log_error("Logical volume %s has multiple "
"mirror segments.", lv->name);
return 0;
next reply other threads:[~2009-05-19 10:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 10:27 mbroz [this message]
2009-05-19 17:15 ` LVM2/tools lvconvert.c Alasdair G Kergon
-- strict thread matches above, loose matches on Subject: below --
2012-04-19 21:50 jbrassow
2012-02-23 22:36 zkabelac
2012-02-22 16:03 jbrassow
2012-02-22 15:20 jbrassow
2012-02-13 18:38 jbrassow
2012-02-13 18:36 jbrassow
2012-01-25 22:38 zkabelac
2011-12-08 18:00 agk
2011-06-29 2:06 jbrassow
2011-06-28 21:28 jbrassow
2011-01-19 19:24 jbrassow
2010-11-28 18:37 snitzer
2010-07-13 22:04 jbrassow
2010-07-13 21:53 jbrassow
2010-07-01 10:10 mornfall
2010-06-23 20:32 jbrassow
2010-06-23 20:49 ` Alasdair G Kergon
2010-06-23 20:56 ` Jonathan Brassow
2010-04-28 17:41 jbrassow
2010-04-26 18:12 agk
2010-04-20 12:18 agk
2010-03-31 20:39 agk
2010-02-05 22:47 snitzer
2010-01-13 1:49 snitzer
2010-01-13 1:47 snitzer
2010-01-11 17:13 jbrassow
2010-01-07 20:42 jbrassow
2009-10-21 22:19 jbrassow
2009-08-02 21:56 mornfall
2009-06-26 11:29 wysochanski
2009-06-10 15:27 mornfall
2009-05-19 10:12 mbroz
2008-01-16 22:54 agk
2008-01-16 19:40 agk
2008-01-16 19:16 agk
2007-12-21 1:08 agk
2007-08-01 20:54 jbrassow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519102747.21668.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.