All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools lvconvert.c
Date: 22 Feb 2012 16:03:56 -0000	[thread overview]
Message-ID: <20120222160356.23322.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	jbrassow at sourceware.org	2012-02-22 16:03:55

Modified files:
	tools          : lvconvert.c 

Log message:
	Add some messages that indicate completion of RAID device replacement.
	
	There were no messages printed upon completiion of RAID device replacement.
	This could cause confusion/concern during automated recovery, because the
	user sees the failure messages but no other messages indicating correction.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.183&r2=1.184

--- LVM2/tools/lvconvert.c	2012/02/22 15:20:50	1.183
+++ LVM2/tools/lvconvert.c	2012/02/22 16:03:55	1.184
@@ -1531,7 +1531,15 @@
 			if (!(failed_pvs = _failed_pv_list(lv->vg)))
 				return_0;
 
-			return lv_raid_replace(lv, failed_pvs, lp->pvh);
+			if (!lv_raid_replace(lv, failed_pvs, lp->pvh)) {
+				log_error("Failed to replace faulty devices in"
+					  " %s/%s.", lv->vg->name, lv->name);
+				return 0;
+			}
+
+			log_print("Faulty devices in %s/%s successfully"
+				  " replaced.", lv->vg->name, lv->name);
+			return 1;
 		}
 
 		/* "warn" if policy not set to replace */



             reply	other threads:[~2012-02-22 16:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 16:03 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-19 21:50 LVM2/tools lvconvert.c jbrassow
2012-02-23 22:36 zkabelac
2012-02-22 15:20 jbrassow
2012-02-13 18:38 jbrassow
2012-02-13 18:36 jbrassow
2012-01-25 22:38 zkabelac
2011-12-08 18:00 agk
2011-06-29  2:06 jbrassow
2011-06-28 21:28 jbrassow
2011-01-19 19:24 jbrassow
2010-11-28 18:37 snitzer
2010-07-13 22:04 jbrassow
2010-07-13 21:53 jbrassow
2010-07-01 10:10 mornfall
2010-06-23 20:32 jbrassow
2010-06-23 20:49 ` Alasdair G Kergon
2010-06-23 20:56   ` Jonathan Brassow
2010-04-28 17:41 jbrassow
2010-04-26 18:12 agk
2010-04-20 12:18 agk
2010-03-31 20:39 agk
2010-02-05 22:47 snitzer
2010-01-13  1:49 snitzer
2010-01-13  1:47 snitzer
2010-01-11 17:13 jbrassow
2010-01-07 20:42 jbrassow
2009-10-21 22:19 jbrassow
2009-08-02 21:56 mornfall
2009-06-26 11:29 wysochanski
2009-06-10 15:27 mornfall
2009-05-19 10:27 mbroz
2009-05-19 17:15 ` Alasdair G Kergon
2009-05-19 10:12 mbroz
2008-01-16 22:54 agk
2008-01-16 19:40 agk
2008-01-16 19:16 agk
2007-12-21  1:08 agk
2007-08-01 20:54 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120222160356.23322.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.