From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, xemul@openvz.org
Subject: Re: [Bridge] [RFC 1/5] net: bridge - use is_multicast_ether_addr helper
Date: Tue, 19 May 2009 15:18:02 -0700 [thread overview]
Message-ID: <20090519151802.22debf54@nehalam> (raw)
In-Reply-To: <20090511125350.555985895@openvz.org>
On Mon, 11 May 2009 15:46:40 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Instead of handwritten constrcution it's better
> to use is_multicast_ether_addr.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> net/bridge/br_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.git/net/bridge/br_device.c
> =====================================================================
> --- linux-2.6.git.orig/net/bridge/br_device.c
> +++ linux-2.6.git/net/bridge/br_device.c
> @@ -32,7 +32,7 @@ int br_dev_xmit(struct sk_buff *skb, str
> skb_reset_mac_header(skb);
> skb_pull(skb, ETH_HLEN);
>
> - if (dest[0] & 1)
> + if (is_multicast_ether_addr(dest))
> br_flood_deliver(br, skb);
> else if ((dst = __br_fdb_get(br, dest)) != NULL)
> br_deliver(dst->dst, skb);
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This is trivial and fine.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, xemul@openvz.org,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [RFC 1/5] net: bridge - use is_multicast_ether_addr helper
Date: Tue, 19 May 2009 15:18:02 -0700 [thread overview]
Message-ID: <20090519151802.22debf54@nehalam> (raw)
In-Reply-To: <20090511125350.555985895@openvz.org>
On Mon, 11 May 2009 15:46:40 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Instead of handwritten constrcution it's better
> to use is_multicast_ether_addr.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> net/bridge/br_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.git/net/bridge/br_device.c
> =====================================================================
> --- linux-2.6.git.orig/net/bridge/br_device.c
> +++ linux-2.6.git/net/bridge/br_device.c
> @@ -32,7 +32,7 @@ int br_dev_xmit(struct sk_buff *skb, str
> skb_reset_mac_header(skb);
> skb_pull(skb, ETH_HLEN);
>
> - if (dest[0] & 1)
> + if (is_multicast_ether_addr(dest))
> br_flood_deliver(br, skb);
> else if ((dst = __br_fdb_get(br, dest)) != NULL)
> br_deliver(dst->dst, skb);
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This is trivial and fine.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2009-05-19 22:18 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 11:46 [Bridge] [RFC 0/5] bridge - introduce via_phys_dev feature Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-11 11:46 ` [Bridge] [RFC 1/5] net: bridge - use is_multicast_ether_addr helper Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-19 22:18 ` Stephen Hemminger [this message]
2009-05-19 22:18 ` Stephen Hemminger
2009-05-11 11:46 ` [Bridge] [RFC 2/5] net: bridge - add managing of BRCTL_SET_VIA_PHYS_DEV and BRCTL_SET_MASTER_DEV Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-11 11:46 ` [Bridge] [RFC 3/5] net: sk_buff - introduce br_seen field to mark skb issued by a bridge Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-11 11:46 ` [Bridge] [RFC 4/5] net: dev.c - introduce br_hard_xmit_hook Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-11 11:46 ` [Bridge] [RFC 5/5] net: bridge - handle via_phys_dev feature on a bridge level Cyrill Gorcunov
2009-05-11 11:46 ` Cyrill Gorcunov
2009-05-11 13:01 ` [Bridge] " Cyrill Gorcunov
2009-05-11 13:01 ` Cyrill Gorcunov
2009-05-12 5:30 ` [Bridge] [RFC 0/5] bridge - introduce via_phys_dev feature Daniel Robbins
2009-05-12 5:30 ` Daniel Robbins
2009-05-12 6:19 ` Cyrill Gorcunov
2009-05-12 6:19 ` Cyrill Gorcunov
2009-05-12 7:02 ` Daniel Robbins
2009-05-12 7:02 ` Daniel Robbins
2009-05-12 16:24 ` Cyrill Gorcunov
2009-05-12 16:24 ` Cyrill Gorcunov
2009-05-12 17:07 ` Daniel Robbins
2009-05-12 17:07 ` Daniel Robbins
2009-05-12 17:21 ` Cyrill Gorcunov
2009-05-12 17:21 ` Cyrill Gorcunov
2009-05-19 22:21 ` Stephen Hemminger
2009-05-19 22:21 ` Stephen Hemminger
[not found] ` <20090520192726.GF4968@lenovo>
[not found] ` <20090520131225.03b7715a@nehalam>
[not found] ` <20090521180805.GC4932@lenovo>
[not found] ` <20090521140504.1865883b@nehalam>
[not found] ` <20090522201850.GF5354@lenovo>
2010-02-26 16:18 ` [Bridge] " Stephen Hemminger
2010-02-26 16:18 ` Stephen Hemminger
2010-02-26 16:51 ` [Bridge] " Cyrill Gorcunov
2010-02-26 16:51 ` Cyrill Gorcunov
2010-02-26 17:39 ` [Bridge] " Pavel Emelyanov
2010-02-26 17:39 ` Pavel Emelyanov
2010-02-26 18:01 ` [Bridge] " Stephen Hemminger
2010-02-26 18:01 ` Stephen Hemminger
2010-02-26 18:08 ` [Bridge] " David Miller
2010-02-26 18:08 ` David Miller
2010-02-26 18:30 ` [Bridge] " Stephen Hemminger
2010-02-26 18:30 ` Stephen Hemminger
2010-02-26 18:40 ` [Bridge] " Ben Greear
2010-02-26 18:40 ` Ben Greear
2010-02-26 18:49 ` [Bridge] " Stephen Hemminger
2010-02-26 18:49 ` Stephen Hemminger
2010-02-26 21:16 ` [Bridge] " Pavel Emelyanov
2010-02-26 21:16 ` Pavel Emelyanov
2010-02-26 18:55 ` [Bridge] " Cyrill Gorcunov
2010-02-26 18:55 ` Cyrill Gorcunov
2010-02-26 19:01 ` [Bridge] " David Miller
2010-02-26 19:01 ` David Miller
2010-02-26 16:52 ` [Bridge] " richardvoigt
2010-02-26 17:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519151802.22debf54@nehalam \
--to=shemminger@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gorcunov@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.