Re: [PATCH 05/13] block: Export I/O topology for block devices and partitions

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, May 19 2009, Martin K. Petersen wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
> 
> >> I really hate the 'alignment' name, nobody will know wtf that is
> >> without looking it up. The rest of the names are fairly self
> >> explanatory.  offset? offset_size? misalignment? Not very good with
> >> names, but perhaps we can find something more appropriate :-)
> 
> Yeah, it's a tricky thing to convey.  And despite all the other
> convergence otherwise happening in the standards, T10 and T13 do not
> agree how to describe the logical/physical alignment.
> 
> 
> Mike> I agree that 'alignment' is too terse/confusing given that it is
> Mike> an offset we're exposing.  How about 'alignment_offset'?
> 
> I thought I had already changed it to alignment_offset like we talked
> about a while ago.  But I guess that change was only done mentally :)
> 
> Jens, are you ok with that name?

I think so, I can't think of anything better :-)

If you repost an updated 5/13 patch and I'll add it to the mix.

-- 
Jens Axboe