From: Jens Axboe <jens.axboe@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
rwheeler@redhat.com, snitzer@redhat.com, jeff@garzik.org,
neilb@suse.de, James.Bottomley@hansenpartnership.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 02/13] block: Use accessor functions for queue limits
Date: Mon, 1 Jun 2009 07:15:57 +0200 [thread overview]
Message-ID: <20090601051556.GU11363@kernel.dk> (raw)
In-Reply-To: <yq1ab4sa6cc.fsf@sermon.lab.mkp.net>
On Mon, Jun 01 2009, Martin K. Petersen wrote:
> >>>>> "Bart" == Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> writes:
>
> >> Convert all external users of queue limits to using wrapper functions
> >> instead of poking the request queue variables directly.
>
> Did bisect this?
>
> The patch you mention didn't touch the bounce limits at all. One of my
> other patches moved portions of the queue limits to an embedded struct.
> However, it was purely variable renaming. I have not touched anything
> related to memory allocations.
It replaces
q->bounce_pfn = t->limits.bounce_pfn;
with
blk_queue_bounce_limit(q, t->limits.bounce_pfn);
which are definitely not a functionally equivalent change.
--
Jens Axboe
next prev parent reply other threads:[~2009-06-01 5:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 4:40 I/O Topology v3 Martin K. Petersen
2009-05-15 4:40 ` [PATCH 01/13] block: Do away with the notion of hardsect_size Martin K. Petersen
2009-05-15 4:40 ` [PATCH 02/13] block: Use accessor functions for queue limits Martin K. Petersen
2009-05-31 15:51 ` Bartlomiej Zolnierkiewicz
2009-06-01 5:08 ` Martin K. Petersen
2009-06-01 5:15 ` Jens Axboe [this message]
2009-06-01 5:28 ` Martin K. Petersen
2009-05-15 4:40 ` [PATCH 03/13] block: Move queue limits to an embedded struct Martin K. Petersen
2009-05-18 18:50 ` Mike Snitzer
2009-05-18 18:52 ` Mike Snitzer
2009-05-19 16:46 ` Martin K. Petersen
2009-05-15 4:40 ` [PATCH 04/13] block: Expose stacked device queues in sysfs Martin K. Petersen
2009-05-15 4:40 ` [PATCH 05/13] block: Export I/O topology for block devices and partitions Martin K. Petersen
2009-05-18 17:57 ` Jens Axboe
2009-05-18 18:12 ` Mike Snitzer
2009-05-19 16:41 ` Martin K. Petersen
2009-05-19 18:15 ` Jens Axboe
2009-05-20 21:19 ` Martin K. Petersen
2009-05-22 7:30 ` Jens Axboe
2009-05-22 13:34 ` Martin K. Petersen
2009-05-22 18:16 ` Jens Axboe
2009-05-15 4:40 ` [PATCH 06/13] MD: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-05-15 4:40 ` [PATCH 07/13] block: Deprecate blk_queue_stack_limits Martin K. Petersen
2009-05-15 4:40 ` [PATCH 08/13] sd: Physical block size and alignment support Martin K. Petersen
2009-05-15 4:40 ` [PATCH 09/13] sd: Detect non-rotational devices Martin K. Petersen
2009-05-15 4:40 ` [PATCH 10/13] sd: Block limits VPD support Martin K. Petersen
2009-05-15 4:40 ` [PATCH 11/13] scsi_debug: Add support for physical block exponent and alignment Martin K. Petersen
2009-05-19 15:11 ` Douglas Gilbert
2009-05-15 4:40 ` [PATCH 12/13] libata: Report disk alignment and physical block size Martin K. Petersen
2009-05-15 18:17 ` Jeff Garzik
2009-05-15 4:40 ` [PATCH 13/13] libata: Media rotation rate and form factor heuristics Martin K. Petersen
2009-05-15 18:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601051556.GU11363@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.