From: Rusty Russell <rusty@rustcorp.com.au>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
jbarnes@virtuousgeek.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_blk: add missing __dev{init,exit} markings
Date: Wed, 20 May 2009 00:10:51 +0930 [thread overview]
Message-ID: <200905200010.51786.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1242632349-15894-1-git-send-email-vapier@gentoo.org>
On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:
> -static int virtblk_probe(struct virtio_device *vdev)
> +static int __devinit virtblk_probe(struct virtio_device *vdev)
This makes sense, I think, but then it implies that virtio_dev_probe() should
also be __devinit, right?
And I look at pci_bus_probe(), and it's not __devinit.
Is the PCI code just slack?
Rusty.
next prev parent reply other threads:[~2009-05-19 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 7:39 [PATCH] virtio_blk: add missing __dev{init,exit} markings Mike Frysinger
2009-05-19 14:40 ` Rusty Russell [this message]
2009-06-26 19:37 ` Jesse Barnes
2009-06-26 19:37 ` Jesse Barnes
2009-05-19 14:40 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905200010.51786.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.