From: Bob Copeland <me@bobcopeland.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath9k: fix custom regulatory call position
Date: Tue, 19 May 2009 20:51:01 -0400 [thread overview]
Message-ID: <20090520005101.GA16051@hash.localnet> (raw)
In-Reply-To: <43e72e890905191542k7e65200en8b6f9453ead1a21a@mail.gmail.com>
On Tue, May 19, 2009 at 03:42:56PM -0700, Luis R. Rodriguez wrote:
> >> @@ -1412,8 +1412,6 @@ static int ath_init(u16 devid, struct ath_softc *sc)
> >> for (i = 0; i < sc->keymax; i++)
> >> ath9k_hw_keyreset(ah, (u16) i);
> >>
> >> - error = ath_regd_init(&sc->sc_ah->regulatory, sc->hw->wiphy,
> >> - ath9k_reg_notifier);
> >> if (error)
> >> goto bad;
> >
> > Is the "if (error)" check still valid?
>
> Sure, although we'll never hit it, we should just make ath_regd_init() void
I should rephrase that as a statement :) You moved the ath_regd_init
but forgot to remove the "if (error) goto bad" part.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-05-20 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 21:49 [PATCH 1/3] ath9k: fix custom regulatory call position Luis R. Rodriguez
2009-05-19 21:49 ` [PATCH 2/3] ath9k: set max default eirp to 20 dBm Luis R. Rodriguez
2009-05-19 21:49 ` [PATCH 3/3] cfg80211: warn when wiphy_apply_custom_regulatory() does nothing Luis R. Rodriguez
2009-05-19 22:05 ` [PATCH 1/3] ath9k: fix custom regulatory call position Johannes Berg
2009-05-19 22:33 ` Bob Copeland
2009-05-19 22:42 ` Luis R. Rodriguez
2009-05-20 0:51 ` Bob Copeland [this message]
2009-05-20 1:25 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520005101.GA16051@hash.localnet \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.