Re: [PATCH 1/3] ath9k: fix custom regulatory call position

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Tue, May 19, 2009 at 05:51:01PM -0700, Bob Copeland wrote:
> On Tue, May 19, 2009 at 03:42:56PM -0700, Luis R. Rodriguez wrote:
> > >> @@ -1412,8 +1412,6 @@ static int ath_init(u16 devid, struct ath_softc *sc)
> > >>        for (i = 0; i < sc->keymax; i++)
> > >>                ath9k_hw_keyreset(ah, (u16) i);
> > >>
> > >> -       error = ath_regd_init(&sc->sc_ah->regulatory, sc->hw->wiphy,
> > >> -                             ath9k_reg_notifier);
> > >>        if (error)
> > >>                goto bad;
> > >
> > > Is the "if (error)" check still valid?
> >
> > Sure, although we'll never hit it, we should just make ath_regd_init() void
> 
> I should rephrase that as a statement :)  You moved the ath_regd_init
> but forgot to remove the "if (error) goto bad" part.

Heh... thanks, will resend.

  Luis