Re: [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Wed, May 20, 2009 at 01:51:02PM +0530, Aggarwal, Anuj wrote:
> Peter Ujfalusi [mailto:peter.ujfalusi@nokia.com]:
> > On Tuesday 19 May 2009 21:58:06 ext Mark Brown wrote:

> > > It seems like the feedback has been pretty much OK so it should be OK
> > > apply the patches - Peter?
> > I also think, that it should be OK to apply this series.

Applied - thanks for your hard work on this!  

BTW, I don't know if you noticed the DAPM changes I pushed the other
day.  One commit in particular, 452c5eaa0d5162e02ffee742ea17540887bc2904, 
might be interesting for TWL4030 - it changes things so that we're in
BIAS_ON whenever there's a bias path active, not only when there's a DAC
or ADC path.  I've got a feeling some of the pop/click stuff may mean
that's not as useful as it might've been in the past.

> [Aggarwal, Anuj] Since different platforms are using different ramp
> values, how should it be handled via the same codec source code? How
> should this be done, without modifying the code base? Or should it be
> done every time user wants to play an audio file?

Since it's just a change in one parameter the driver should be able to
arrange to get that configuration value provided to it via platform
data.  It's still the same chip and needs the same driver, all that's
changing is configuration information.