From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "ext Aggarwal, Anuj" <anuj.aggarwal@ti.com>,
"sakoman@gmail.com" <sakoman@gmail.com>,
"getarunks@gmail.com" <getarunks@gmail.com>,
ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix
Date: Wed, 20 May 2009 12:08:25 +0300 [thread overview]
Message-ID: <200905201208.25645.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB03057419D3@dbde02.ent.ti.com>
On Wednesday 20 May 2009 11:21:02 ext Aggarwal, Anuj wrote:
> [Aggarwal, Anuj] Since different platforms are using different ramp values,
> how should it be handled via the same codec source code? How should this be
> done, without modifying the code base? Or should it be done every time user
> wants to play an audio file?
I think we should leave the ramp delay configurable, since it is easier to
'port' the codec to a new board.
We can add - as Mark already suggested - a platform data parameter for the
twl4030 codec driver to set the correct ramp delay value for the given board.
The actual user will still have means to change it, but if the correct ramp
delay has been found for the board, the pop attenuation would work out of box
on the boards.
--
Péter
prev parent reply other threads:[~2009-05-20 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 13:02 [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix Peter Ujfalusi
2009-05-18 13:02 ` [PATCH 1/2] ASoC: TWL4030: Change DAPM routings and controls for DACs and PGAs Peter Ujfalusi
2009-05-18 13:02 ` [PATCH 2/2] ASoC: TWL4030: Move the Headset pop-attenuation code to PGA event Peter Ujfalusi
2009-05-18 13:09 ` [PATCH 0/2] ASoC: TWL4030: DAPM restructuring and Headset pop-attenuation fix Mark Brown
2009-05-18 15:28 ` Aggarwal, Anuj
2009-05-19 0:48 ` Lopez Cruz, Misael
2009-05-19 6:47 ` Aggarwal, Anuj
2009-05-19 8:00 ` Peter Ujfalusi
2009-05-19 8:30 ` Aggarwal, Anuj
2009-05-19 6:46 ` Peter Ujfalusi
2009-05-19 7:33 ` Jarkko Nikula
2009-05-19 18:58 ` Mark Brown
2009-05-20 5:56 ` Peter Ujfalusi
2009-05-20 8:21 ` Aggarwal, Anuj
2009-05-20 8:51 ` Mark Brown
2009-05-20 9:12 ` Peter Ujfalusi
2009-05-21 10:47 ` Aggarwal, Anuj
2009-05-21 11:06 ` Mark Brown
2009-05-20 9:08 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905201208.25645.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=getarunks@gmail.com \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.