From: Karsten Keil <keil@b1-systems.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
i4ldeveloper@listserv.isdn4linux.de
Subject: Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti
Date: Wed, 20 May 2009 11:19:48 +0200 [thread overview]
Message-ID: <200905201119.48782.keil@b1-systems.de> (raw)
In-Reply-To: <87y6ssnr5v.fsf@basil.nowhere.org>
Hi Andi,
On Mittwoch, 20. Mai 2009 09:56:44 Andi Kleen wrote:
> Karsten Keil <keil@b1-systems.de> writes:
> > --- a/drivers/isdn/hardware/mISDN/hfc_multi.h
> > +++ b/drivers/isdn/hardware/mISDN/hfc_multi.h
> > @@ -18,6 +18,46 @@
> > #define PCI_ENA_MEMIO 0x02
> >
> > /*
> > + * Defines for the SDG embedded board using the XHFC-4SU chip
> > + */
> > +#ifdef CONFIG_8xx
>
> This seems like a awfully generic name for a (likely global) CONFIG. Can
> you add a descriptive prefix?
>
> -Andi
This config is not set by mISDN, it is set by somepowerpc sub arch.
Karsten
next prev parent reply other threads:[~2009-05-20 9:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 13:27 [PATCH 00/19] mISDN update for linux-next Karsten Keil
2009-05-19 13:58 ` [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti Karsten Keil
2009-05-19 19:11 ` David Miller
2009-05-20 3:13 ` Marcel Holtmann
2009-05-20 9:12 ` Karsten Keil
2009-05-20 19:38 ` David Miller
2009-05-20 7:56 ` Andi Kleen
2009-05-20 9:19 ` Karsten Keil [this message]
2009-05-20 11:38 ` Andi Kleen
2009-05-20 12:18 ` Karsten Keil
2009-05-20 16:59 ` Karsten Keil
2009-05-19 13:58 ` [PATCH 03/19] Add PCI ID for Junghanns 8S card Karsten Keil
2009-05-19 13:58 ` [PATCH 02/19] Fix bug in XHFC registering Karsten Keil
2009-05-19 13:58 ` [PATCH 04/19] Add watchdog functionality to hfcmulti driver Karsten Keil
2009-05-19 13:58 ` [PATCH 05/19] DSP now uses ring buffer for echo canceler Karsten Keil
2009-05-19 13:58 ` [PATCH 06/19] Fix hfcmulti's PCI IRQ bug during init Karsten Keil
2009-05-19 13:58 ` [PATCH 07/19] Echo canceler now gets delay information from hardware Karsten Keil
2009-05-19 13:58 ` [PATCH 08/19] Fixed missing spin lock on pipeline process Karsten Keil
2009-05-19 13:58 ` [PATCH 09/19] Reduce stack size in dsp_cmx_send() Karsten Keil
2009-05-19 13:58 ` [PATCH 10/19] Added layer-1-hold feature Karsten Keil
2009-05-19 13:58 ` [PATCH 11/19] Fix DTMF locking bug issue Karsten Keil
2009-05-19 13:58 ` [PATCH 12/19] Hardware acceleration is now possible in conjunction with audio recording Karsten Keil
2009-05-19 13:58 ` [PATCH 13/19] Fix TEI and SAPI handling Karsten Keil
2009-05-19 13:58 ` [PATCH 14/19] Add "sapi" information to debug messages Karsten Keil
2009-05-19 13:58 ` [PATCH 16/19] Add allocation of recvbuf[1500] at run time to reduce stack size Karsten Keil
2009-05-19 13:58 ` [PATCH 15/19] Added PCI ID for new Junghanns.net Single E1 cards Karsten Keil
2009-05-19 13:58 ` [PATCH 17/19] Fix skb leak in error cases Karsten Keil
2009-05-19 13:58 ` [PATCH 18/19] Cleanup debug messages Karsten Keil
2009-05-19 13:58 ` [PATCH 19/19] isdn: get_free_devid() failure ignored Karsten Keil
2009-05-19 22:22 ` [PATCH 00/19] mISDN update for linux-next Stephen Rothwell
2009-05-20 1:42 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905201119.48782.keil@b1-systems.de \
--to=keil@b1-systems.de \
--cc=andi@firstfloor.org \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.