From: Chris Wright <chrisw@sous-sol.org>
To: Alex Williamson <alex.williamson@hp.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"Yang, Sheng" <sheng.yang@intel.com>, Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] KVM: Fix potentially recursively get kvm lock
Date: Fri, 22 May 2009 08:06:23 -0700 [thread overview]
Message-ID: <20090522150623.GD20823@sequoia.sous-sol.org> (raw)
In-Reply-To: <1242166650.4788.16.camel@2710p.home>
* Alex Williamson (alex.williamson@hp.com) wrote:
> On Tue, 2009-05-12 at 19:09 -0300, Marcelo Tosatti wrote:
> > KVM: workaround workqueue / deassign_host_irq deadlock
> >
> > I think I'm running into the following deadlock in the kvm kernel module
> > when trying to use device assignment:
> >
> > CPU A CPU B
> > kvm_vm_ioctl_deassign_dev_irq()
> > mutex_lock(&kvm->lock); worker_thread()
> > -> kvm_deassign_irq() ->
> > kvm_assigned_dev_interrupt_work_handler()
> > -> deassign_host_irq() mutex_lock(&kvm->lock);
> > -> cancel_work_sync() [blocked]
> >
> > Workaround the issue by dropping kvm->lock for cancel_work_sync().
> >
> > Reported-by: Alex Williamson <alex.williamson@hp.com>
> > From: Sheng Yang <sheng.yang@intel.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Perfect, thanks.
>
> Acked-by: Alex Williamson <alex.williamson@hp.com>
Is this still pending?
thanks,
-chris
next prev parent reply other threads:[~2009-05-22 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 9:05 device-assignment deadlock Yang, Sheng
2009-05-12 9:32 ` [PATCH 1/1] KVM: Fix potentially recursively get kvm lock Sheng Yang
2009-05-12 11:55 ` Marcelo Tosatti
2009-05-12 14:13 ` Yang, Sheng
2009-05-12 14:30 ` Marcelo Tosatti
2009-05-12 15:59 ` Marcelo Tosatti
2009-05-12 19:44 ` Marcelo Tosatti
2009-05-12 21:36 ` Alex Williamson
2009-05-12 22:09 ` Marcelo Tosatti
2009-05-12 22:17 ` Alex Williamson
2009-05-22 15:06 ` Chris Wright [this message]
2009-05-22 15:34 ` Alex Williamson
2009-05-22 15:36 ` Chris Wright
2009-05-13 2:07 ` Yang, Sheng
2009-05-13 13:14 ` Marcelo Tosatti
2009-05-13 11:43 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090522150623.GD20823@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=alex.williamson@hp.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.