From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, donald.c.skidmore@intel.com,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load.
Date: Tue, 26 May 2009 20:40:57 -0700 (PDT) [thread overview]
Message-ID: <20090526.204057.193339971.davem@davemloft.net> (raw)
In-Reply-To: <20090527005403.28535.8727.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 26 May 2009 17:54:04 -0700
> If we loaded the driver with out a SFP module plugged in it would
> leave it in a state that make it later unable to link when a module
> was plugged in. This patch corrects that by:
>
> ixgbe_probe() - moving the check for IXGBE_ERR_SFP_NOT_PRESENT from
> after get_invariants() to after reset_hw() as now reset_hw() is
> where this condition will be indentified.
>
> ixgbe_reset_hw_82598() - Enable this function to now return
> IXGBE_ERR_SFP_NOT_PRESENT.
>
> ixgbe_identify_sfp_module_generic() - This where the lack of SFP
> module is detected. Modifications are added to allow a different
> return value for modules that just haven't been plugged in yet.
>
> Other functions were updated to allow correct logging.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2009-05-27 3:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:54 [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load Jeff Kirsher
2009-05-27 0:54 ` [net-next-2.6 PATCH 2/4] ixgbe: fix driver loading with unsupported module on 82598 Jeff Kirsher
2009-05-27 1:28 ` Ben Hutchings
2009-05-27 3:41 ` David Miller
2009-05-27 0:54 ` [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations Jeff Kirsher
2009-05-27 3:38 ` David Miller
2009-05-27 11:16 ` Ben Hutchings
2009-05-27 20:52 ` David Miller
2009-05-29 0:01 ` Duyck, Alexander H
2009-05-29 0:04 ` David Miller
2009-05-27 0:55 ` [net-next-2.6 PATCH 4/4] ixgbe: Remove device ID 0x10d8 Jeff Kirsher
2009-05-27 3:40 ` David Miller
2009-05-27 3:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526.204057.193339971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.