From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
donald.c.skidmore@intel.com, peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-next-2.6 PATCH 2/4] ixgbe: fix driver loading with unsupported module on 82598
Date: Tue, 26 May 2009 20:41:56 -0700 (PDT) [thread overview]
Message-ID: <20090526.204156.21027711.davem@davemloft.net> (raw)
In-Reply-To: <1243387737.16597.140.camel@deadeye>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 27 May 2009 02:28:57 +0100
> On Tue, 2009-05-26 at 17:54 -0700, Jeff Kirsher wrote:
>> From: Don Skidmore <donald.c.skidmore@intel.com>
>>
>> We will now need to store the phy address which we do in the hw->phy
>> struct. Likewise we no longer need the mdio struct in hw->phy along
>> with the mdio functions ixgbe_mdio_write(read) which have been
>> removed. ixgbe_ioctl was no longer used and referenced hw->phy.mdio
>> so it was also removed.
>
> The ioctl is for the benefit of user-space!
Indeed, this is completely bogus. I'm not applying this.
next prev parent reply other threads:[~2009-05-27 3:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:54 [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load Jeff Kirsher
2009-05-27 0:54 ` [net-next-2.6 PATCH 2/4] ixgbe: fix driver loading with unsupported module on 82598 Jeff Kirsher
2009-05-27 1:28 ` Ben Hutchings
2009-05-27 3:41 ` David Miller [this message]
2009-05-27 0:54 ` [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations Jeff Kirsher
2009-05-27 3:38 ` David Miller
2009-05-27 11:16 ` Ben Hutchings
2009-05-27 20:52 ` David Miller
2009-05-29 0:01 ` Duyck, Alexander H
2009-05-29 0:04 ` David Miller
2009-05-27 0:55 ` [net-next-2.6 PATCH 4/4] ixgbe: Remove device ID 0x10d8 Jeff Kirsher
2009-05-27 3:40 ` David Miller
2009-05-27 3:40 ` [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526.204156.21027711.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=donald.c.skidmore@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.