From: Paul Mundt <lethal@linux-sh.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Christoph Lameter <cl@linux-foundation.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH] Warn if we run out of swap space
Date: Tue, 26 May 2009 12:29:34 +0900 [thread overview]
Message-ID: <20090526032934.GC9188@linux-sh.org> (raw)
In-Reply-To: <4A1A057A.3080203@oracle.com>
On Sun, May 24, 2009 at 07:42:02PM -0700, Randy Dunlap wrote:
> KOSAKI Motohiro wrote:
> >> + if (!printed) {
> >> + printed = 1;
> >> + printk(KERN_WARNING "All of swap is in use. Some pages cannot be swapped out.");
> >> + }
> >
> > Why don't you use WARN_ONCE()?
>
> Someone earlier in this patch thread (maybe Pavel?) commented that
> WARN_ONCE() would cause a stack dump and that would be too harsh,
> especially for users. I.e., just the message is needed here, not a
> stack dump.
>
Note that this is precisely what we have printk_once() for these days,
which will do what this patch is doing already. Of course if the variable
will be reset, then it is best left as is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-26 3:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 18:58 [PATCH] Warn if we run out of swap space Christoph Lameter
2009-05-22 20:47 ` Pavel Machek
2009-05-23 4:38 ` Andrew Morton
2009-05-25 0:53 ` KAMEZAWA Hiroyuki
2009-05-24 13:44 ` KOSAKI Motohiro
2009-05-25 2:42 ` Randy Dunlap
2009-05-26 0:40 ` KOSAKI Motohiro
2009-05-26 1:05 ` Randy Dunlap
2009-05-26 1:08 ` KOSAKI Motohiro
2009-05-26 3:29 ` Paul Mundt [this message]
2009-05-26 14:23 ` Christoph Lameter
2009-05-26 20:15 ` Andrew Morton
2009-05-26 20:45 ` Randy Dunlap
2009-05-26 20:55 ` Andrew Morton
2009-05-27 0:25 ` KAMEZAWA Hiroyuki
2009-05-26 20:54 ` Christoph Lameter
2009-05-26 21:01 ` Andrew Morton
2009-05-26 21:05 ` Christoph Lameter
2009-05-27 0:42 ` KAMEZAWA Hiroyuki
2009-05-27 13:54 ` Christoph Lameter
2009-06-04 6:02 ` KOSAKI Motohiro
2009-06-01 16:19 ` Avi Kivity
2009-06-01 17:29 ` Christoph Lameter
2009-06-01 17:38 ` Avi Kivity
2009-06-01 19:35 ` Andrew Morton
2009-06-01 19:44 ` Avi Kivity
2009-06-02 9:14 ` Pavel Machek
2009-06-02 9:19 ` Avi Kivity
2009-06-02 9:15 ` Pavel Machek
2009-06-02 9:21 ` Avi Kivity
2009-06-02 9:30 ` Pavel Machek
2009-06-02 9:50 ` Avi Kivity
2009-06-02 9:23 ` Avi Kivity
2009-06-02 9:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526032934.GC9188@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.