From: Paul Mundt <lethal@linux-sh.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
rtc-linux@googlegroups.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems
Date: Tue, 26 May 2009 20:22:40 +0900 [thread overview]
Message-ID: <20090526112240.GA16835@linux-sh.org> (raw)
In-Reply-To: <20090526102502.GA24737@infradead.org>
On Tue, May 26, 2009 at 06:25:02AM -0400, Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 06:10:33AM -0400, Mike Frysinger wrote:
> > tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > - && !ARM && !SUPERH && !S390 && !AVR32
> > + && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN
>
> Maybe it's better to have a positive dependency for those that actually
> support it these days? Based on the above list that would be:
>
> depends on ALPHA || CRIS || H8300 || M32R || MICROBLAZE ||
> MIPS || MN10300 || SH || X86 || XTENSA
>
> and I would not be surprised if some of the above don't actually support
> it either..
SH shouldn't be included it, we've never supported it. Out of the ones
that do support this interface, I would guess that they should require
little to no modification to work with drivers/rtc/rtc-cmos.c.
Out of the ones that don't actually support this interface but never
bothered updating the Kconfig bits.. none of h8300/microblaze/xtensa
define any of the CMOS_READ/WRITE() accessors, so this has no chance at
all of working there.
Now to narrow that list down a bit more, both m32r and cris primarily use
this interface for their ds1302 RTC, which I added a stub driver for in
drivers/rtc/rtc-ds1302.c some time ago. With a bit of cleanup on the
driver side and a bit of a push from the architecture side, they should
also be able to just use the drivers/rtc version directly. I've offered
to help with the conversion for these platforms before, but neither
maintainer seemed terribly responsive.
Which basically leaves just alpha, mips, mn10300, and x86. I would be
surprised if these don't work with rtc-cmos already today.
next prev parent reply other threads:[~2009-05-26 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 10:10 [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems Mike Frysinger
2009-05-26 10:25 ` Christoph Hellwig
2009-05-26 10:28 ` [rtc-linux] " Mike Frysinger
2009-05-26 11:22 ` Paul Mundt [this message]
2009-05-26 20:30 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526112240.GA16835@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.